[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v12 03/10] admin: introduce group administration commands
On Tue, Apr 25, 2023 at 01:38:21PM +0000, Parav Pandit wrote: > > > > From: Michael S. Tsirkin <mst@redhat.com> > > Sent: Tuesday, April 25, 2023 9:32 AM > > > > I am requesting to drop the commit point that limits the usage of the AQ. > > > Do you agree that AQ can be extended for use beyond VF and SIOV group > > management commands? > > > Or one should create a new VQ type? > > > If it is the later, I don't see the need of multiple AQ. > > > > not management. that is old term and indeed too narrow. > > administration as in hypervisor (admin) access through PF while guest has > > access through VF. > > > > legacy access you link to below seems to fall within scope: > > we access VF through a PF. > > > > So what is the problem? > > > Commit log confused me. You clarified above. > It is clear now. Hence no problem. > > > maybe we'll change the meaning down the road. I do not see the immediate > > need currently though. > > > As long as we agree that it is open to widen the scope, it is acceptable. > > > > [1] > > > https://lists.oasis-open.org/archives/virtio-dev/202304/msg00511.html > > > > Then I don't see a problem. It's just commit log, not spec. Let it slide is my > > suggestion, this is spec text not code. > > Ok. I feel it is still worth to have commit log updated. If you happen to revise v13, please do. > Else its fine. > > v12 surely doesn't merge cleanly. So v13 is needed anyway. > > Can you please generate? Patch-5 of v12 fails to apply. should apply on top of 985bbf397db4228faf3ec464e838687dc4cb4904. master will fail because of the file movement. I will need to rebase to apply on latest master, I will do it before we start voting. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]