RE: [ws-sx] Issue 120: minor editorial comments on Trust andWS-SecureConversation

[Marc Goodner <mgoodner@microsoft.com>]

I agree with most of your comments, there are a few I disagree with. I've included my thoughts inline below. Thanks, Marc g

-----Original Message-----
From: Greg Carpenter [mailto:gregcarp@microsoft.com]
Sent: Monday, November 27, 2006 12:25 PM
To: NISHIMURA Toshihiro; ws-sx@lists.oasis-open.org
Subject: [ws-sx] Issue 120: minor editorial comments on Trust and WS-SecureConversation

 Issue 120.

> -----Original Message-----
> From: NISHIMURA Toshihiro [mailto:nishimura.toshi@jp.fujitsu.com]
> Sent: Wednesday, November 22, 2006 2:18 AM
> To: ws-sx@lists.oasis-open.org
> Subject: [ws-sx] New issue: minor editorial comments on Trust
> and WS-SecureConversation
>
> Protocol:  ws-trust, ws-sc
>
> http://www.oasis-open.org/apps/org/workgroup/ws-sx/download.ph
> p/21285/ws-trust-1.3-spec-cs-01.pdf
>
> http://www.oasis-open.org/apps/org/workgroup/ws-sx/download.ph
> p/21307/ws-secureconversation-1.3-spec-cs-01.pdf
>
> Artifact:  spec
>
> Type: editorial
>
> Title: minor editorial comments on Trust and WS-SecureConversation
>
> Description:
>
> On WS-Trust:
>
> Line 346-348,357: Duplicated description.
> Though L346-348 says using dateTime and UTC time is
> RECOMMENDED, L357 says all time references use dateTime and UTC.
> Remove L357, or modify L357 using "RECOMMENDED".
>

MG: I agree this is a duplicate, I think striking line 357 would be the better option.

> Line 422: "recipient" would be "requestor"
>

MG: I think this is unnecessary, in context of the text they are synonymous.

> Line 431: change "RST" to "RSTR"
>

MG: I believe RST is correct here.

> Line 677,679: change "wsp:Claims" to "wst:Claims"
>

MG: Good catch.

>
> On WS-SecureConversation:
>
> Line 537-538: I think "over the security context signature
> created using ..." would be "over the security context using ..."
>

MG: I believe this text is correct as it is discussing how to sign over an SCT based signature.

> Line 819: remove "is as follows"
>

MG: Yes, that is better.

> Line 857: change "label" to "nonce"
>

MG: Another good catch.

> Line 779-781,883: different default value. I think L883
> should be changed. (change
> "WS-SecureConversationWS-SecureConversation" to
> "WS-SecureConversation")
>

MG: The TC already worked through this to arrive at the current value. See issue 105.

> Line 884: duplicated periods ("..") at the end of line. remove one.
>

MG: Agreed.

> Line 1044: change "wsse:Security>" to "<wsse:Security>"
>

MG: Agreed.

> Proposal:
> As written above.
>
> Related Issues:
> None
> ---
> NISHIMURA Toshihiro (FAMILY Given)
> nishimura.toshi@jp.fujitsu.com
> STRATEGY AND TECHNOLOGY DIV., SOFTWARE UNIT, FUJITSU LIMITED
>
>