[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [sca-j] ISSUE 111: Proposed resolution - take 3
One more small tweak - see point 10 below. The rest is unchanged. Simon The following line numbers refer to sca-javacaa-1.1-spec-cd01-rev2.pdf. 1. Delete line 1044. 2. On line 1048, add the following sentence: "If this constructor has parameters, each of these parameters MUST have either a @Property annotation or a @Reference annotation." 3. Delete lines 1049 through 1052. 4. Replace line 1062 by: public HelloServiceImpl (@Property(name="someProperty") String someProperty) { 5. Replace lines 1381 through 1382 by ". name (optional) - the name of the property. For a field annotation, the default is the name of the field of the Java class. For a setter method annotation, the default is the JavaBeans property name corresponding to the setter method name. For a constructor parameter annotation, there is no default and the name attribute MUST be present." 6. On line 1383, add "For a constructor parameter annotation, this attribute MUST have the value true." 7. Replace lines 1441 through 1442 by ". name (optional) - the name of the reference. For a field annotation, the default is the name of the field of the Java class. For a setter method annotation, the default is the JavaBeans property name corresponding to the setter method name. For a constructor parameter annotation, there is no default and the name attribute MUST be present." 8. On line 1443, add "For a constructor parameter annotation, this attribute MUST have the value true." 9. Replace line 1453 by: public void setStockQuote( StockQuoteService theSQService ) { .... } 10. On line 1383, change "defaults to false" to "defaults to false for a field or setter method annotation and to true for a constructor parameter annotation". Simon Simon Nash wrote: > Mike, > Thanks for catching this omission from my proposed resolution for JAVA-111. > Here's a revised proposal that includes this, and also corrects a line > numbering problem. > > The following line numbers refer to sca-javacaa-1.1-spec-cd01-rev2.pdf. > > 1. Delete line 1044. > > 2. On line 1048, add the following sentence: "If this constructor has > parameters, each of these parameters MUST have either a @Property > annotation or a @Reference annotation." > > 3. Delete lines 1049 through 1052. > > 4. Replace line 1062 by: > public HelloServiceImpl (@Property(name="someProperty") String > someProperty) { > > 5. Replace lines 1381 through 1382 by ". name (optional) - the name of > the property. For a field annotation, the default is the name of the > field of the Java class. For a setter method annotation, the default > is the JavaBeans property name corresponding to the setter method > name. For a constructor parameter annotation, there is no default > and the name attribute MUST be present." > > 6. On line 1383, add "For a constructor parameter annotation, this > attribute MUST have the value true." > > 7. Replace lines 1441 through 1442 by ". name (optional) - the name of > the reference. For a field annotation, the default is the name of the > field of the Java class. For a setter method annotation, the default > is the JavaBeans property name corresponding to the setter method > name. For a constructor parameter annotation, there is no default > and the name attribute MUST be present." > > 8. On line 1443, add "For a constructor parameter annotation, this > attribute MUST have the value true." > > 9. Replace line 1453 by: > public void setStockQuote( StockQuoteService theSQService ) { > .... > } > > Simon > > Mike Edwards wrote: >> >> Folks, >> >> +1 to this proposal. >> >> Can I ask if there is going to be a change to the @Constructor >> annotation definition which will place a requirement >> for there to be either @Property or @Reference annotations on each >> parameter of the constructor which is annotated >> with @Constructor? If we don't require this, then I don't see where >> the name of the reference or property can come from >> since the names of the parameters are not available at runtime. >> >> If there is going to be a change for @Constructor, which Issue will do >> this? >> >> Yours, Mike. >> >> Strategist - Emerging Technologies, SCA & SDO. >> Co Chair OASIS SCA Assembly TC. >> IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain. >> Phone & FAX: +44-1962-818014 Mobile: +44-7802-467431 Email: >> mike_edwards@uk.ibm.com >> >> >> From: Simon Nash <oasis@cjnash.com> >> To: sca-j@lists.oasis-open.org >> Date: 15/12/2008 10:22 >> Subject: [sca-j] ISSUE 111: Proposed resolution >> >> >> ------------------------------------------------------------------------ >> >> >> >> The following line numbers refer to sca-javacaa-1.1-spec-cd01-rev2.pdf. >> >> 1. Delete line 1044. >> >> 2. Delete lines 1049 through 1052. >> >> 3. Replace line 1062 by: >> public HelloServiceImpl (@Property(name="someProperty") String >> someProperty) { >> >> 4. Replace lines 1344 through 1345 by ". name (optional) - the name of >> the property. For a field annotation, the default is the name of the >> field of the Java class. For a setter method annotation, the default >> is the JavaBeans property name corresponding to the setter method >> name. For a constructor parameter annotation, there is no default >> and the name attribute MUST be present." >> >> 5. Replace lines 1441 through 1442 by ". name (optional) - the name of >> the reference. For a field annotation, the default is the name of the >> field of the Java class. For a setter method annotation, the default >> is the JavaBeans property name corresponding to the setter method >> name. For a constructor parameter annotation, there is no default >> and the name attribute MUST be present." >> >> 6. Replace line 1453 by: >> public void setStockQuote( StockQuoteService theSQService ) { >> .... >> } >> >> >> --------------------------------------------------------------------- >> To unsubscribe from this mail list, you must leave the OASIS TC that >> generates this mail. Follow this link to all your TCs in OASIS at: >> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php >> >> >> >> >> >> >> ------------------------------------------------------------------------ >> >> / >> / >> >> /Unless stated otherwise above: >> IBM United Kingdom Limited - Registered in England and Wales with >> number 741598. >> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 >> 3AU/ >> >> >> >> >> >> > > > > --------------------------------------------------------------------- > To unsubscribe from this mail list, you must leave the OASIS TC that > generates this mail. Follow this link to all your TCs in OASIS at: > https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php > >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]