Re: [virtio-dev] [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

[Alvaro Karsz <alvaro.karsz@solid-run.com>]

Hi Parav,

> > +A driver SHOULD NOT negotiate VIRTIO_NET_F_HASH_REPORT if it does not
> > +negotiate VIRTIO_NET_F_CTRL_VQ.
> > +
> Same for the driver too.
> Like below.
> The driver should not negotiate a feature that requires to use a control VQ when VIRTIO_NET_F_CTRL_VQ is not negotiated.

The dependency of VIRTIO_NET_F_HASH_REPORT on VIRTIO_NET_F_CTRL_VQ is
not mentioned in the spec (directly at least).
So I'm not so sure about this line.

All the dependencies are listed in the "Feature bit requirements" section.
VIRTIO_NET_F_HASH_REPORT is missing, but since 1.2 is out, we can't
add it now as a requirement [1] [2].

[1] https://github.com/oasis-tcs/virtio-spec/issues/158
[2] https://lists.oasis-open.org/archives/virtio-comment/202302/msg00027.html

> Or driver must not .. ..
> Exception to that is VIRTIO_NET_F_HASH_REPORT, which driver should avoid negotiation ...