OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [virtio-comment] [PATCH v3] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature


> From: Alvaro Karsz <alvaro.karsz@solid-run.com>
> Sent: Wednesday, February 15, 2023 11:19 AM
> 
> > > +\begin{note}
> > > +In general, these commands are best-effort: spurious notifications could
> still arrive.
> > > +\end{note}
> >
> > This is quite vague. How about:
> >
> > The behaviour of the device in response to these commands is
> > best-effort: the device may generate notifications more frequently
> > than specified, for example after less than \field{max_packets}
> > packets have been processed or less than \field{usecs} usecs time has
> elapsed.
> >
> Looks good to me.
> I'll add it to v4 if nobody objects.

small improvement below.

s/more frequently/more or less frequently.

This is because when LSO or LRO is ongoing, packet count or timer may have reached, but user buffer notification wouldnât occur, because used ring updates are not yet done. There is no partial completion. So, notification can be less frequent. Hence, the wording should be "more or less".


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]