OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: Re: [virtio-comment] [PATCH v3] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature


On Wednesday, 2023-02-15 at 18:45:14 +02, Alvaro Karsz wrote:
>> > +\begin{note}
>> > +In general, these commands are best-effort: spurious notifications could still arrive.
>> > +\end{note}
>>
>> This is quite vague. How about:
>>
>> The behaviour of the device in response to these commands is
>> best-effort: the device may generate notifications more frequently than
>> specified, for example after less than \field{max_packets} packets have
>> been processed or less than \field{usecs} usecs time has elapsed.
>>
>
> On second thought, this may be a little confusing.
> The device can send a notification before processing max_packets
> packets, if usecs elapsed (and vice versa).
> So it should be "less than \field{max_packets} packets have been
> processed AND less than \field{usecs} usecs ..."
>
> How about dropping the example?

Given Parav's comment as well, drop the example, yes.
-- 
Don't worry, Mary, cause I'm taking care of Danny, and he's taking care of me.


[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]