OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH v9 3/8] transport-mmio: Rename QueueNum register


On Wed, Mar 29 2023, Parav Pandit <parav@nvidia.com> wrote:

>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Wednesday, March 29, 2023 5:16 AM
>> 
>> I'm not sure it is worthwile keeping the lines short so aggressively (after all, it
>> does not affect the generated html/pdf), especially as it makes the diff a bit
>> harder to read, but I don't have a strong objection to it.
>>
> I agree, 80 or 100 characters should be reasonable based on Linux kernel experience.
>
> The short line requirement came from [1].
> Shall I change [1] to 80 characters?
>
> [1] https://github.com/oasis-tcs/virtio-spec/blob/b0414098602fbdb0bc5efa4ff06ea6cae8123ed4/_vimrc#L5

I wasn't even aware of that file, as I don't use vim... in any case, 65
seems way too short, especially as many (most?) lines are already longer
than that. 80 (or 100) seems more reasonable.

Michael, do you remember where the 65 came from? Is that anything we
still care about?



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]