OASIS Mailing List ArchivesView the OASIS mailing list archive below
or browse/search using MarkMail.

 


Help: OASIS Mailing Lists Help | MarkMail Help

virtio-comment message

[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]


Subject: RE: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number


On Wed, Mar 29 2023, Parav Pandit <parav@nvidia.com> wrote:

>> From: Cornelia Huck <cohuck@redhat.com>
>> Sent: Wednesday, March 29, 2023 5:30 AM
>> 
>> Same comment regarding s/Previously/previously/ as for the last patch.
>>
> Will change.
>  
>> Also, I'm not that happy with the name "queue_select". Sure, it matches what
>> pci and mmio use, but ccw does not quite use the same mechanism:
>> vq_config_block is not a structure that always exists where the meaning of the
>> fields is controlled by a selector field, but a structure that is provided by the
>> caller and then filled to refer to a certain vq. I'd prefer this field to be named
>> "vq_num" or something like that.
>
> Rest of the spec uses "vqn" at places. 
> So I will change queue_select to vqn.
> Are you ok with "vqn"?

vqn works for me.



[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]