Re: [virtio-comment] RE: [PATCH] virtio-net: Fix virtio_net_hdr struct size when VIRTIO_NET_F_HASH_REPORT is negotiated.

[Parav Pandit <parav@nvidia.com>]

On 5/3/2023 9:39 AM, Cyril Germond wrote:
> From: Cyril Germond <cgermond@kalray.eu>
> Sent: Monday, November 21, 2022 10:03 AM
>
> Hard-coded references to the size of virtio_net_hdr strut are wrong when VIRTIO_NET_HASH_REPORT feature is negotiated.
Please fix spelling,
s/strut/struct

Below changelog should be after "---", so that it doesnt become part of 
the commit log.
>   
>   \subsection{Message Framing}\label{sec:Basic Facilities of a Virtio Device / Virtqueues / Message Framing}  The framing of messages with descriptors is -independent of the contents of the buffers. For example, a network
> +independent of the contents of the buffers. For example, if
> +VIRTIO_NET_F_HASH_REPORT has not been negotiated, a network
>   transmit buffer consists of a 12 byte header followed by the network  packet. This could be most simply placed in the descriptor table as a
>   12 byte output descriptor followed by a 1514 byte output descriptor,

Above change does not look correct as the example is for the Tx.
and HASH_REPORT is for the RX.

Once you post the new version as v1 with above fixes, please update the 
link in the github issue as well.