RE: [virtio-comment] RE: [PATCH] virtio-net: Fix virtio_net_hdr struct size when VIRTIO_NET_F_HASH_REPORT is negotiated.

[Cyril Germond <cgermond@kalrayinc.com>]

Hello
I agree VIRTIO_NET_HASH_REPORT feature is for incoming packets path.
Nevertheless, it seems - at least to me but I may be wrong there - that the packet header structure data type - as described in chapter 5.1.6 Device Operation - is the same for the Rx and TX packets.
Thus, if VIRTIO_NET_HASH_REPORT feature is negotiated, even for a Rx only feature, , the same virtio_net_hdr structure size should be used for both Rx and TX packets. Am I wrong ?
Thanks,

-----Original Message-----
From: Parav Pandit <parav@nvidia.com> 
Sent: Wednesday, May 3, 2023 6:33 PM
To: Cyril Germond <cgermond@kalrayinc.com>; virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-comment] RE: [PATCH] virtio-net: Fix virtio_net_hdr struct size when VIRTIO_NET_F_HASH_REPORT is negotiated.



On 5/3/2023 9:39 AM, Cyril Germond wrote:
> From: Cyril Germond <cgermond@kalray.eu>
> Sent: Monday, November 21, 2022 10:03 AM
> 
> Hard-coded references to the size of virtio_net_hdr strut are wrong when VIRTIO_NET_HASH_REPORT feature is negotiated.
Please fix spelling,
s/strut/struct

Below changelog should be after "---", so that it doesnt become part of the commit log.
>   
>   \subsection{Message Framing}\label{sec:Basic Facilities of a Virtio 
> Device / Virtqueues / Message Framing}  The framing of messages with 
> descriptors is -independent of the contents of the buffers. For 
> example, a network
> +independent of the contents of the buffers. For example, if 
> +VIRTIO_NET_F_HASH_REPORT has not been negotiated, a network
>   transmit buffer consists of a 12 byte header followed by the network  packet. This could be most simply placed in the descriptor table as a
>   12 byte output descriptor followed by a 1514 byte output descriptor,

Above change does not look correct as the example is for the Tx.
and HASH_REPORT is for the RX.

Once you post the new version as v1 with above fixes, please update the link in the github issue as well.