[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v16 03/11] content: Rename confusing queue_notify_data and vqn names
On Thu, May 04, 2023 at 06:33:38PM +0000, Parav Pandit wrote: > > > From: David Edmondson <david.edmondson@oracle.com> > > Sent: Thursday, May 4, 2023 10:28 AM > > > > \begin{description} > > > -\item [vqn] VQ number to be notified. > > > +\item [vq_index_config_data] Either virtqueue index or device supplied > > > + queue notification config data corresponding to a virtqueue. > > > > vq_index_config_data doesn't exist. > > > > Given that this is an anonymous union, perhaps: > > > > \item [vq_index or vq_notif_config_data] Either ... > > > > \drivernormative{\paragraph}{Available Buffer Notifications}{Virtio > > > Transport Options / Virtio Over PCI Bus / PCI-specific Initialization And Device > > Operation / Available Buffer Notifications} -If VIRTIO_F_NOTIF_CONFIG_DATA > > has been negotiated: > > > + > > > +If VIRTIO_F_NOTIFICATION_DATA is not negotiated, the driver > > > +notification MUST be a 16-bit notification. > > > + > > > +If VIRTIO_F_NOTIFICATION_DATA is negotiated, the driver notification > > > +MUST be a 32-bit notification. > > > > The above two should be inside itemize? > > Both suggestions look good to me. > Given rest of the patches are reviewed and it is already v16, I think I can cover them right after this in editorial changes after merging this. > This way the majority of the work of this series and subsequent patches doesn't need to wait another week. Did voting start already? If not you can post a new version just before voting if you already know what you want to do. -- MST
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]