Re: [PATCH 2/2] virtio: pci support virtqueue selective enabling

["Michael S. Tsirkin" <mst@redhat.com>]

On Tue, Jun 06, 2023 at 07:55:11PM +0200, Eugenio Pérez wrote:
> Reusing virtqueue reset method to enabling a vq.
> 
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>  transport-pci.tex | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/transport-pci.tex b/transport-pci.tex
> index a5c6719..04c0429 100644
> --- a/transport-pci.tex
> +++ b/transport-pci.tex
> @@ -375,6 +375,10 @@ \subsubsection{Common configuration structure layout}\label{sec:Virtio Transport
>  
>  \item[\field{queue_enable}]
>          The driver uses this to selectively prevent the device from executing requests from this virtqueue.
> +        If the driver negotiates VIRTIO_F_RING_ENABLE_ANYTIME or
> +        VIRTIO_F_RING_RESET, the driver writes 1 to this field to enable a
> +        virtqueue.  See \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Selective Virtqueue Enable}
> +        and \ref{sec:Basic Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}.
>          1 - enabled; 0 - disabled.

No, this is always used to enable queues even with no features.

>  \item[\field{queue_notify_off}]
> -- 
> 2.31.1