RE: [virtio-comment] RE: [PATCH v19] virtio-net: support inner header hash

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Thursday, June 29, 2023 7:48 AM


> > > struct virtio_net_hash_config reserved is fine.
> >
> > +1.
> >
> > Inner header hash is orthogonal to RSS, and it's fine to have its own
> > structure and commands.
> > There is no need to send additional RSS fields when we configure inner
> > header hash.
> >
> > Thanks.
> 
> Not RSS, hash calculations. It's not critical, but I note that practically you said
> you will enable this with symmetric hash so it makes sense to me to send this in
> the same command with the key.
> 

In the v19, we have,

+\item[VIRTIO_NET_F_HASH_TUNNEL] Requires VIRTIO_NET_F_CTRL_VQ along with VIRTIO_NET_F_RSS or VIRTIO_NET_F_HASH_REPORT.

So it is done along with rss, so in same struct as rss config is fine.