Re: [PATCH v7 3/4] admin: Add group member legacy register access commands

["Michael S. Tsirkin" <mst@redhat.com>]

On Thu, Jun 29, 2023 at 10:02:53PM +0000, Parav Pandit wrote:
> 
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Thursday, June 29, 2023 5:57 PM
> 
> > > I have mixed feelings; I think definition in transport and link in generic section
> > is fine.
> > > Are you ok with that?
> > 
> > I am yet to focus on wording, can't tell you for sure.  My gut feeling is that
> > keeping everything in one place would be more readable, will help us converge
> > more quickly, and the next user of admin commands is expected to be SIOV
> > which would need the same structure anyway (it's also PCI).
> >
> Ok. For v8 I will have link and keep in pci transport section. Later I can move as union if needed.

I can do that too.

> SIOV for PCI and CXL will look very different, so SIOV legacy I am not expecting any change for these commands.

SIOV will need a notification structure within BAR, and it could reuse the same
one.

> > Also look at virtio_pci_notify_cap and check whether any normative statements
> > there should apply here. Alignment I guess?
> 
> I will move below normative from pci to generic.
> 
> The group member driver SHOULD use the notification region supplied by the group owner driver.

By owner device.

-- 
MST