RE: [PATCH v14] admin: Add group member legacy register access commands

[Parav Pandit <parav@nvidia.com>]

> From: Michael S. Tsirkin <mst@redhat.com>
> Sent: Monday, July 10, 2023 12:35 PM

[..]

> > +The \field{flags} value of 0x1 indicates that the notification
> > +address is of the owner device, value of 0x2 indicates that the
> > +notification address is of the member device, the value of 0
> > +indicates that all the entries starting from
> 
> , the -> and value of 0x0
> 
> 
> > +that entry are invalid entries in \field{entries}. All other values
> > +in \field{flags} are reserved.
> > +
> > +The \field{bar} values 0x1 to 0x5 specify BAR1 to BAR5 respectively:
> > +when the \field{flags} is 0x1 this is specified by the Base Address
> > +Registers in the PCI header of the device, when the \field{flags} is
> > +0x2 this is specified by the VF BARn registers in the SR-IOV Extended
> > +Capability of the device.
> > +
> > +The \field{offset} indicates the notification address relative to BAR
> > +indicated in \field{bar}. This value is 2-byte aligned.
> > +
> > +When the command completes successfully,
> > +\field{command_specific_result} is in the format of \field{struct
> virtio_admin_cmd_legacy_notify_info_result}.
> 
> 
> > The
> > +device can supply up to 4 entries each with a different notification
> > +address. In this case, any of the entries can be used by the driver.
> > +The order of the entries serves as a preference hint to the driver.
> > +The driver is expected to utilize the entries placed earlier in the array to the
> later ones.
> 
> to -> in preference to
> 
> > The driver is
> > +also expected to ignore any reserved entries and to skip all invalid entries.
> 
> is there a difference between ignore and skip?
> And what are reserved entries?
>
Reserved entries are the entries which has value > 0x2 for future.
 
> 	The driver is also expected to ignore any invalid entries, as well
> 	as the end of list entry if present and any entries following
> 	the end of list.
> 

	The driver is also expected to ignore any invalid or reserved entries, as well
	as the end of list entry if present and any entries following
	the end of list.

Please see above if addition of "or reserved" looks fine.
Will fix rest of the comments now.