Re: [virtio-comment] [PATCH 0/2] Selective queue enabling

[Jason Wang <jasowang@redhat.com>]

On Mon, Jul 10, 2023 at 1:49âPM Michael S. Tsirkin <mst@redhat.com> wrote:
>
> On Mon, Jul 10, 2023 at 11:55:50AM +0800, Jason Wang wrote:
> > On Fri, Jul 7, 2023 at 2:19âAM Eugenio Perez Martin <eperezma@redhat.com> wrote:
> > >
> > > On Tue, Jun 6, 2023 at 7:55âPM Eugenio PÃrez <eperezma@redhat.com> wrote:
> > > >
> > > > This series allows the driver to start the device (as set DRIVER_OK) with only
> > > > some queues enabled, and then enable another queues later.
> > > >
> > > > This is the current way to migrate net device state through control
> > > > virtqueue, in a software assisted framework with vDPA:
> > > > * First, only net CVQ is enabled at DRIVER_OK
> > > > * All the control commands (mac address, mq, etc) needed for the device
> > > > to behave the same as the source of migration are sent
> > > > * Finally all the dataplane queues are enabled.
> > > >
> > >
> > > Adding Yan to the thread, who mentioned that he is looking for
> > > something similar in the virtio-networking upstream meeting.
> >
> > Would there be a V2?
> >
> > Thanks
>
> I'm not sure we need to bother at this point. In linux
> we seem to have agreed to use a mix of RING_RESET and
> a vdpa specific thing.

The question is:

1) This proposal is pretty compact and self contained
2) Some vDPA device and vhost devices already behave like this
3) Using RING_RESET requires a lot of codes and tricks

This makes me wonder if this proposal is still the better way to go.

Thanks

> Non-vdpa solutions don't seem to
> need this.
> Right Parav?
>
> > >
> > > > Eugenio PÃrez (2):
> > > >   virtio: introduce selective queue enabling
> > > >   virtio: pci support virtqueue selective enabling
> > > >
> > > >  content.tex       | 15 +++++++++++++--
> > > >  transport-pci.tex |  4 ++++
> > > >  2 files changed, 17 insertions(+), 2 deletions(-)
> > > >
> > > > --
> > > > 2.31.1
> > > >
> > > >
> > > >
> > > > This publicly archived list offers a means to provide input to the
> > > > OASIS Virtual I/O Device (VIRTIO) TC.
> > > >
> > > > In order to verify user consent to the Feedback License terms and
> > > > to minimize spam in the list archive, subscription is required
> > > > before posting.
> > > >
> > > > Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> > > > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> > > > List help: virtio-comment-help@lists.oasis-open.org
> > > > List archive: https://lists.oasis-open.org/archives/virtio-comment/
> > > > Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> > > > List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> > > > Committee: https://www.oasis-open.org/committees/virtio/
> > > > Join OASIS: https://www.oasis-open.org/join/
> > > >
> > >
>