Re: [virtio-comment] virtio sound: add missing definitions for 12 and 24kHz sampling rates

[Manos Pitsidianakis <manos.pitsidianakis@linaro.org>]

On Wed, 29 Nov 2023 at 10:24, Anton Yakovlev
<anton.yakovlev@opensynergy.com> wrote:
>
> Hi Manos, Andreas,
>
> Actually, I think it would make sense to add 12kHz, 24kHz and also 352800kHz
> to the list of supported frame rates.
>
>
> Kind regards,
>

Andreas, would you mind re-sending the patch inline as a new thread
with git-send-email instead of an attachment? And we can then review
it formally.



> On 12.11.2023 23:04, Manos Pitsidianakis wrote:
> > Hello Andreas,
> >
> > The spec says it is purposely modeled to be compatible with the HDA spec. HDA
> > is optimized for specific multiples or submultiples of 44.1 kHz and 48 kHz.
> > Specifically, look at "5.4 Handling Stream Independent Sample Rates" and
> > "Table 56. Defined Sample Rates". My (unexperienced) understanding of the
> > following statement is that using such rates with controller hardware that is
> > made for HDA will result in timing issues:
> >
> >> This implies that the controller and link must also provide for an exact
> >> sample-rendering rate at the codec, in order to avoid any long term drift
> >> between sample delivery and rendering and the subsequent over(under)-run of
> >> codec buffers.
> >
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fwww.intel.com%2fcontent%2fdam%2fwww%2fpublic%2fus%2fen%2fdocuments%2fproduct%2dspecifications%2fhigh%2ddefinition%2daudio%2dspecification.pdf&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-cb72c66b78900b97f31176a2a470cdf7d28d8f94
> >
> > If that is the case, I think the best approach would be to specify a non-HDA
> > mode of operation to support more sound hardware. The most straight-forward
> > solution though is for you to resample the audio before and after it goes
> > through virtio-sound.
> >
> >
> > Regards,
> >
> > -- Manos Pitsidianakis
> > Emulation and Virtualization Engineer at Linaro Ltd
> >
> > This publicly archived list offers a means to provide input to the
> > OASIS Virtual I/O Device (VIRTIO) TC.
> >
> > In order to verify user consent to the Feedback License terms and
> > to minimize spam in the list archive, subscription is required
> > before posting.
> >
> > Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> > List help: virtio-comment-help@lists.oasis-open.org
> > List archive:
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2flists.oasis%2dopen.org%2farchives%2fvirtio%2dcomment%2f&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-0fef9f465f0a04da9ccd68a483603afa78faeb94
> > Feedback License:
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fwww.oasis%2dopen.org%2fwho%2fipr%2ffeedback%5flicense.pdf&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-0620b2dca8947547caf1be09cb1b9460071d9c3c
> > List Guidelines:
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fwww.oasis%2dopen.org%2fpolicies%2dguidelines%2fmailing%2dlists&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-7f81dc376e1bb26c4ccd422a6585c18e105f677a
> > Committee:
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fwww.oasis%2dopen.org%2fcommittees%2fvirtio%2f&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-e64745d0015d08f4923c010538fce9ec55d679ff
> > Join OASIS:
> > https://ddec1-0-en-ctp.trendmicro.com:443/wis/clicktime/v1/query?url=https%3a%2f%2fwww.oasis%2dopen.org%2fjoin%2f&umid=d569f403-01a9-4519-8038-4bb35906ff78&auth=53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-0474f1d3e724132ee586e990891b08a79f61f539
>
> --
> Anton Yakovlev
> Senior Software Engineer
>
> OpenSynergy GmbH
> Rotherstr. 20, 10245 Berlin