[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: RE: [virtio-comment] virtio sound: add missing definitions for 12 and 24kHz sampling rates
Hi Manos,
>Andreas, would you mind re-sending the patch inline as a new thread with git-send-email instead of an attachment? And we can then review it formally.
sorry, have no mbox access on my devel machine, so here at least as 'inline' patch.
From 067de7a6676dad3ecaaf2316661b0f0057a19cd2 Mon Sep 17 00:00:00 2001
From: Andreas Pape <apape@de.adit-jv.com>
Date: Thu, 9 Nov 2023 16:14:57 +0100
Subject: [PATCH] sound: add sampling rates 12000Hz and 24000Hz
24kHz is used for 'super wideband' voice transmission
12kHz is added 'for completeness'
Signed-off-by: Andreas Pape <apape@de.adit-jv.com>
---
device-types/sound/description.tex | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
index 54c9c8e..bad4415 100644
--- a/device-types/sound/description.tex
+++ b/device-types/sound/description.tex
@@ -504,7 +504,9 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
VIRTIO_SND_PCM_RATE_96000,
VIRTIO_SND_PCM_RATE_176400,
VIRTIO_SND_PCM_RATE_192000,
- VIRTIO_SND_PCM_RATE_384000
+ VIRTIO_SND_PCM_RATE_384000,
+ VIRTIO_SND_PCM_RATE_12000,
+ VIRTIO_SND_PCM_RATE_24000
};
struct virtio_snd_pcm_info {
--
2.7.4
Regards
Andreas
-----Original Message-----
From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Sent: Mittwoch, 29. November 2023 11:00
To: Pape, Andreas (ADITG/ESS3) <apape@de.adit-jv.com>; Anton Yakovlev <anton.yakovlev@opensynergy.com>
Cc: virtio-comment@lists.oasis-open.org
Subject: Re: [virtio-comment] virtio sound: add missing definitions for 12 and 24kHz sampling rates
On Wed, 29 Nov 2023 at 10:24, Anton Yakovlev <anton.yakovlev@opensynergy.com> wrote:
>
> Hi Manos, Andreas,
>
> Actually, I think it would make sense to add 12kHz, 24kHz and also
> 352800kHz to the list of supported frame rates.
>
>
> Kind regards,
>
Andreas, would you mind re-sending the patch inline as a new thread with git-send-email instead of an attachment? And we can then review it formally.
> On 12.11.2023 23:04, Manos Pitsidianakis wrote:
> > Hello Andreas,
> >
> > The spec says it is purposely modeled to be compatible with the HDA
> > spec. HDA is optimized for specific multiples or submultiples of 44.1 kHz and 48 kHz.
> > Specifically, look at "5.4 Handling Stream Independent Sample Rates"
> > and "Table 56. Defined Sample Rates". My (unexperienced)
> > understanding of the following statement is that using such rates
> > with controller hardware that is made for HDA will result in timing issues:
> >
> >> This implies that the controller and link must also provide for an
> >> exact sample-rendering rate at the codec, in order to avoid any
> >> long term drift between sample delivery and rendering and the
> >> subsequent over(under)-run of codec buffers.
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252fwww.intel.com-252fcontent-252fdam-252fwww-252fpublic-252fu
> > s-252fen-252fdocuments-252fproduct-252dspecifications-252fhigh-252dd
> > efinition-252daudio-252dspecification.pdf-26umid-3Dd569f403-2D01a9-2
> > D4519-2D8038-2D4bb35906ff78-26auth-3D53c7c7de28b92dfd96e93d9dd61a23e
> > 634d2fbec-2Dcb72c66b78900b97f31176a2a470cdf7d28d8f94&d=DwIFaQ&c=euGZ
> > stcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=aWTtojMtCV9SvyEwkpBNuTjVnz
> > Mm-Wc09ONKDmVeCUo&m=bMgr9gHtFkQVyd4PUiCK6_Vh6rHeSO00o8OX1s74k4ijjmKt
> > rwc8ZclqTYe-rwVj&s=C4PXCALcOBpPDNeGIWkB7vsmQ5xaPjMSbQnLkkrVlFE&e=
> >
> > If that is the case, I think the best approach would be to specify a
> > non-HDA mode of operation to support more sound hardware. The most
> > straight-forward solution though is for you to resample the audio
> > before and after it goes through virtio-sound.
> >
> >
> > Regards,
> >
> > -- Manos Pitsidianakis
> > Emulation and Virtualization Engineer at Linaro Ltd
> >
> > This publicly archived list offers a means to provide input to the
> > OASIS Virtual I/O Device (VIRTIO) TC.
> >
> > In order to verify user consent to the Feedback License terms and to
> > minimize spam in the list archive, subscription is required before
> > posting.
> >
> > Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> > Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> > List help: virtio-comment-help@lists.oasis-open.org
> > List archive:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252flists.oasis-252dopen.org-252farchives-252fvirtio-252dcomme
> > nt-252f-26umid-3Dd569f403-2D01a9-2D4519-2D8038-2D4bb35906ff78-26auth
> > -3D53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-2D0fef9f465f0a04da9ccd68
> > a483603afa78faeb94&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnV
> > fiiMM&r=aWTtojMtCV9SvyEwkpBNuTjVnzMm-Wc09ONKDmVeCUo&m=bMgr9gHtFkQVyd
> > 4PUiCK6_Vh6rHeSO00o8OX1s74k4ijjmKtrwc8ZclqTYe-rwVj&s=bE42_ADUpUKXqoY
> > HPjF5jId4ZcCnadR-gcZNX0p_l34&e=
> > Feedback License:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252fwww.oasis-252dopen.org-252fwho-252fipr-252ffeedback-255fli
> > cense.pdf-26umid-3Dd569f403-2D01a9-2D4519-2D8038-2D4bb35906ff78-26au
> > th-3D53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-2D0620b2dca8947547caf1
> > be09cb1b9460071d9c3c&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_Cdpg
> > nVfiiMM&r=aWTtojMtCV9SvyEwkpBNuTjVnzMm-Wc09ONKDmVeCUo&m=bMgr9gHtFkQV
> > yd4PUiCK6_Vh6rHeSO00o8OX1s74k4ijjmKtrwc8ZclqTYe-rwVj&s=ckJUT8QAnsUsx
> > -2fLzVGpKp4IwskoblvcZy94Xq0hk0&e=
> > List Guidelines:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252fwww.oasis-252dopen.org-252fpolicies-252dguidelines-252fmai
> > ling-252dlists-26umid-3Dd569f403-2D01a9-2D4519-2D8038-2D4bb35906ff78
> > -26auth-3D53c7c7de28b92dfd96e93d9dd61a23e634d2fbec-2D7f81dc376e1bb26
> > c4ccd422a6585c18e105f677a&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A
> > _CdpgnVfiiMM&r=aWTtojMtCV9SvyEwkpBNuTjVnzMm-Wc09ONKDmVeCUo&m=bMgr9gH
> > tFkQVyd4PUiCK6_Vh6rHeSO00o8OX1s74k4ijjmKtrwc8ZclqTYe-rwVj&s=XkE8xofk
> > 2zPmxpUTxrGH_5iblgB0klKi5m6WKqChmyQ&e=
> > Committee:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252fwww.oasis-252dopen.org-252fcommittees-252fvirtio-252f-26um
> > id-3Dd569f403-2D01a9-2D4519-2D8038-2D4bb35906ff78-26auth-3D53c7c7de2
> > 8b92dfd96e93d9dd61a23e634d2fbec-2De64745d0015d08f4923c010538fce9ec55
> > d679ff&d=DwIFaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=aWTt
> > ojMtCV9SvyEwkpBNuTjVnzMm-Wc09ONKDmVeCUo&m=bMgr9gHtFkQVyd4PUiCK6_Vh6r
> > HeSO00o8OX1s74k4ijjmKtrwc8ZclqTYe-rwVj&s=4bK318HHAjzY50iMBH5gUsl-mFw
> > W627wnR8ZpGdCmHQ&e=
> > Join OASIS:
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__ddec1-2D0-2Den-
> > 2Dctp.trendmicro.com-3A443_wis_clicktime_v1_query-3Furl-3Dhttps-253a
> > -252f-252fwww.oasis-252dopen.org-252fjoin-252f-26umid-3Dd569f403-2D0
> > 1a9-2D4519-2D8038-2D4bb35906ff78-26auth-3D53c7c7de28b92dfd96e93d9dd6
> > 1a23e634d2fbec-2D0474f1d3e724132ee586e990891b08a79f61f539&d=DwIFaQ&c
> > =euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=aWTtojMtCV9SvyEwkpBNu
> > TjVnzMm-Wc09ONKDmVeCUo&m=bMgr9gHtFkQVyd4PUiCK6_Vh6rHeSO00o8OX1s74k4i
> > jjmKtrwc8ZclqTYe-rwVj&s=XqitxUGXDo3BcSAQyz0IvpRBl8gemYcxNSUIj8EiWBw&
> > e=
>
> --
> Anton Yakovlev
> Senior Software Engineer
>
> OpenSynergy GmbH
> Rotherstr. 20, 10245 Berlin
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]