Comments on BrokeredN WSDL

[Matthew I Roberts <matt.roberts@uk.ibm.com>]

Dave/Lily,

One of my colleagues has noticed the following problems (five in total) in
the BrokeredNotification WSDLs that we would like to see addressed as part
of v1.3 - apologies if they have already been addressed.

Thanks in advance,

Matt


Matt Roberts
WS-Notification Architect and Team Lead
IBM WebSphere Messaging Design and Development
Hursley Park, England. +44 1962 815444
matt.roberts@uk.ibm.com
MP 211 / DE3H22

=======================================================

1. In the NotificationBroker portType, the subscribe operation is defined
as:

      <wsdl:operation name="Subscribe">
            <wsdl:input message="wsnt:SubscribeRequest" />
            <wsdl:output message="wsnt:SubscribeResponse" />
            <wsdl:fault name="ResourceUnknownFault"
                  message="wsnt:ResourceUnknownFault" />
            <wsdl:fault name="SubscribeCreationFailedFault"
                  message="wsnt:SubscribeCreationFailedFault" />
      </wsdl:operation>

yet in the BaseNotification wsdl NotificationProducer portType, it is
defined as:

      <wsdl:operation name="Subscribe">
         <wsdl:input  message="wsntw:SubscribeRequest" />
         <wsdl:output message="wsntw:SubscribeResponse" />
         <wsdl:fault  name="ResourceUnknownFault"
                      message="wsntw:ResourceUnknownFault" />
         <wsdl:fault  name="TopicPathDialectUnknownFault"
                      message="wsntw:TopicPathDialectUnknownFault"/>
         <wsdl:fault  name="InvalidTopicExpressionFault"
                      message="wsntw:InvalidTopicExpressionFault" />
         <wsdl:fault  name="TopicNotSupportedFault"
                      message="wsntw:TopicNotSupportedFault" />
         <wsdl:fault  name="UnsupportedTopicExpressionFault"
                      message="wsntw:UnsupportedTopicExpressionFault"/>
         <wsdl:fault  name="SubscribeCreationFailedFault"
                      message="wsntw:SubscribeCreationFailedFault"/>
      </wsdl:operation>

The latter one should be used in BrokeredNotification wsdl should be used
in both.


2. Many of the operations in the NotificationBroker portType refer to
messages using the wsnt prefix e.g.

      <wsdl:operation name="Notify">
            <wsdl:input message="wsnt:Notify" />
      </wsdl:operation>

This prefix is declared as:

xmlns:wsnt="http://docs.oasis-open.org/wsn/2004/09/wsn-WS-BaseNotification-1.3-draft-01.xsd";

This is incorrect as the messages from the BaseNotification wsdl document
are in the namespace
"http://docs.oasis-open.org/wsn/2004/09/wsn-WS-BaseNotification-1.3-draft-01.wsdl";
 - note the .wsdl on the end rather than .xsd. (the actual base spec 1.3
draft says /yyyy/mm/ rather than /2004/09/ but I realise that's just
because it's not finalized). A different prefix needs to be declared and
used for the
"http://docs.oasis-open.org/wsn/2004/09/wsn-WS-BaseNotification-1.3-draft-01.wsdl";
 namespace

In a similar fashion, there are also references to messages using the wsrp
prefix that need to be changed since wsrp is the prefix for the
WS-ResourceProperties schema namespace not the wsdl one, and references to
messages using the wsrl prefix that need to be changed since wsrl is the
prefix for the WS-ResourceLifetime schema namespace not the wsdl one.


3. The following declaration in the wsdl:

<xsd:element name="NotificationBrokerRP">
      <xsd:complexType>
            <xsd:sequence>
                  <!-- From NotificationProducer -->
                  <xsd:element ref="wsnt:Topic" minOccurs="1"
                        maxOccurs="unbounded" />
                  <xsd:element ref="wsnt:FixedTopicSet"
                        minOccurs="1" maxOccurs="1" />
                  <xsd:element ref="wsnt:TopicExpressionDialects"
                        minOccurs="1" maxOccurs="unbounded" />
                  <!-- NotificationBroker specific  -->
                  <xsd:element ref="wsbn:RequiresRegistration"
                        minOccurs="1" maxOccurs="1" />
            </xsd:sequence>
      </xsd:complexType>
</xsd:element>

incorrectly referes to a non-existent element wsnt:Topic This should be
wsnt:TopicExpression

4. The namespace for ws-addressing needs to be updated to the current
version (and one used by BaseNotification documents) i.e.
"http://schemas.xmlsoap.org/ws/2004/08/addressing";  This needs correcting
the the BrokeredNotification xsd file as well.

5. The BrokeredNotification wsdl defines a ResourceUnkownFaultType and
ResourceUnkownFault. These duplicate what is defined in the WS-Resource
xsd. Some places in the WSDL refer the the type defined
BrokeredNotification version but the BrokeredNotification also refers to
messages in WS-Resource which can in turn refer to the WS-Resource version
of the type. WS-Notification should use the WS-Resource version to avoid
problems. As a side note: currently the BrokeredNotification wsdl does not
import the WS-Resource WSDL yet refers to messages in it! This needs
fixing.