comments on XAdES profile wd-02

[Trevor Perrin <trevp@trevp.net>]

Hi Juan Carlos,

Some comments, mostly editorial -


The title should probably include "Abstract", like: "XAdES Abstract Profile 
of the..."

The abstract could be updated to match the current template, which no 
longer refers to protocol profiles: "This draft profiles the OASIS DSS core 
protocols for the purpose of creating and verifying XAdES signatures".

The Introduction could be updated too.

The schema namespace URL could be made consistent with the core, by 
changing the filename to "oasis-dss-1.0-profiles-XAdES-wd-02".

Line 100 can be deleted.

Section 2.1 could be changed to say: "This profile does not specify a URI 
Identifier".

Line 122: remove both occurences of "to" from this sentence.

Section 2.2: I would move all of the text here except the first sentence to 
a new section "1.3 Overview (Non-normative)".

Issue 1.1: it seems like this draft does have the ability to add arbitrary 
signed properties?

Sections 2.5 and 2.6: Since this is an abstract profile, you can just say: 
"This profile does not specify or constrain the XXXX binding."

Line 200: <SignatureType> has no type attribute.

Issue #3: I'm not sure what this version applies to.  But you could always 
introduce new URIs to do versioning, so I'd say you could leave it out.

Section 3.1.1.3: It's not necessary to use <ClaimedIdentity> for the server 
to know which certificate to use.  For example, maybe you authenticate with 
a username/password, and the server automatically knows which certificates 
goes with your account.  I think you should reword this and omit 
<ClaimedIdentity>.

Line 320: "DocsToB[e]TimeS[t]amped" misspelled.

Issue #4: The <dss:SignedReferences> optional input has a RefId attribute, 
that can be used to set ds:Reference/@Id.  However, I think it would be 
better to refer to the input document with WhichDocument, like you're 
doing, and let the server set ds:Reference/@Id automatically.

Lines 404 and 407: Maybe rephrase using "SHALL" instead of "MUST".

Section 4.1.2.2: Is this a mistake?


Trevor