[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: review of editor's notes for attributes of namespace style
Hi Patrick, I had a look at the editor's notes for attributes of namespace style of our ODF 1.2 specification, committee draft 1. Here are my proposed solutions/questions/comments: - ed. note in "18.471 style:char" The value of style:char can be any UNICODE character. Thus, the value range for this attribute is quite large. Its data type is character. - ed. note in "18.474 style:condition" The first sentence is somehow a future ed. note. For the rest I have no objections to the made changes indicated by the ed- note. - ed. notes in "18.475.1 General" and "18.475.22 <text:variable-set>" No input from my side - data styles are not my playground ;-) - first ed. note in "18.476 style:default-outline-level" "display as a heading" does not sound good to me - the paragraph really becomes a heading. What about the following text"... by an user interface action of an office application, then the paragraph becomes a heading of the given outline level."? - second ed. note in "18.476 style:default-outline-level" I'm fine this the deletion of this text, when it is clear to everybody what the semantic of an empty value for this attribute is. - ed. note in "18.479 style:distance" When you have defined a drop cap, e.g., the first 5 characters of a paragraph should be display spanning over two normal text lines, then style:distance specify the distance between the last character of these 5 characters and the first characters of the first and second text lines. - ed. notes in "18.485 style:font-charset", "18.486 style:font-family-generic" and "18.487 style:font-pitch" I see no reason, why we should deprecate these attributes. What does the others think? - ed. note in "18.488 style:height" I do not know the exact definition of data type percent, but we should assure that we use a positive percentage value for this attribute. Right? - ed. note in "18.491 style:leader-style" Ok. - ed. note in "18.492 style:leader-text" Yes, the schema should reflect the restriction - Michael, changing its data type to character? No further input from my side, because I am also a little bit confused. - ed. note in "18.498 style:length" Yes, I also think that "word" is locale specific. - ed. note in "18.500 style:lines" Yes, if data type is positiveInteger, then value 0 does not make sense. If a drop cap only spans over one line, then the drop cap is displayed as normal text, which somehow means there is no drop cap. I think that was the reason for the text, that the drop cap is disabled, if it spans only over one line. - ed. note in "18.502 style:list-style-name" Made changes, mentioned in the ed. note, are Ok for me. Probably, a similar text could be inserted for style:default-outline-level. - first ed. note in "18.506 style:num-format I agree. I propose to do this for our next ODF version. - second ed. note in "18.506 style:num-format For me the current name of this attribute is Ok. If I am alone with my opinion I propose to change the name in our next ODF version. My Ok for the added text about no value. - ed. note in "18.510 style:page-layout-name" Presentation notes, Handouts and Master pages are not my playground ;-) - ed. note in "18.512 style:parent-style-name" IMHO, default styles for all used style families are needed inside a certain ODF instance. - ed. note in "18.518 style:rfc-language-tag" not my playground. - ed. note in "18.520 style:style-name" Ok. - ed. note in "19.238 style:background-transparency" I agree. It seems we need a new data type - something like positivePercent. Value range for this attribute should be [0%...100%]. - ed. notes in "19.239 style:border-line-width" Michael, is this solved? If yes, let us remove these ed. notes. - ed. note in "19.243 style:border-line-width-top" I agree. - ed. note in "19.244 style:cell-protect" I also think we should define these values. Spreadsheet experts stand up, please ;-) - ed. note in "19.245 style:column-width" Ok for my side. - ed. note in "19.246 style:country-asian" I think we should say "It may be ignored if it is not specified together with style:language-asian attribute.". style:language-asian is the corresponding language attribute for style:country-asian, I think. Please somebody correct me, if I am wrong. The same for style:country-complex - corresponding language attribute is style:language-complex. - ed. note in "19.252 style:diagonal-tl-br-widths" Ok for me. - ed. note in "19.253 style:direction" I do not know - charts and spreadsheets are not my playground ;-) - first part of ed. note in "19.257 style:flow-with-text" Language change is Ok for me. The non-text flow direction paragraph mean the following: - In horizontal left-to-right layout (lr-tb) and in horizontal right-to-left layout (rl-tb) a drawing object is allowed to leave its layout environment to the left and to the right, if the layout environmnet is not table cell area or frame area. In vertical right-to-left layout (tb-rl) a drawing object is allowed to leave its layout environment to the top and to the bottom, if the layout environmnet is not table cell area or frame area. I hope this helps to adjust the wording/language of this paragraph. - second part of ed. note in "19.257 style:flow-with-text" "layout environments" are more or less a short hand reference to a set of container elements. - ed. notes in "19.258" - "19.265", "19.270" - "19.272" and "19.281" - "19.283" I see no reason, why we should deprecate these attributes. What does the others think? - ed. note in "19.267 style:font-name" The deletion of the text is fine for me - no need to do it explicit. - ed. note in "19.269 style:font-name-complex" I think this ed. note also holds for style:font-name-asian and style:font-name. Correct? I do not know, if the made change is Ok. Somebody else as to step in. - ed. notes in "19.274 style:font-size-asian" I see no reason for deprecation. Adding the two final paragraphs is ok for me. - ed. notes in "19.275 style:font-size-complex" I do not know, if we want to switch to XSL 1.1. I see no reason for deprecation. Adding the two final paragraphs is ok for me. - ed. notes in "19.279", "19.280", "19.284" and "19.285" I think we also have three fonts - one for CTL, one for CJK and one for the rest. Thus, we need for each of these fonts its own attributes. Please somebody correct me, if I am wrong. - ed. note in "19.287 style:glyph-orientation-vertical" I have no idea - spreadsheet experts are needed here. - ed. note in "19.298 style:layout-grid-lines" Ok. - ed. notes in "19.303 style:layout-grid-snap-to" and "19.304 style:layout-grid-standard-mode" No input from my side on this. Somebody else? - ed. note in "19.305 style:line-break" I agree, but I do not know such a reference. - ed. note in "19.310 style:min-row-height" I would answer "Yes", but spreadsheet experts should also comment this ed. note. - ed. note in "19.311 style:mirror" I am fine with the deletion of the text. - ed. notes in "19.312 style:num-format" [see above] - ed. note in "19.324 style:protect" I have no answer to this question, because I was not involved in the initial creation of this text. - ed. note in "19.326 style:register-true" Ok for me. - ed. note in "19.328 style:rel-column-width" Ok for me. - ed. note in "19.330.1 <style:graphic-properties> I think the third paragraph should be replaced by the omitted one (inclusive correction of typo). The current third paragraph is a copy from sub chapter "19.329" - ed. note in "19.330.2 <style:table-properties> The paragraph from ODF 1.2 draft 6 - namely "Every table must have a fixed width. This width is specified by the style:width attribute." is currently missing here. Thus, please include it, then I am fine with the ed. note. - ed. note in "19.339 style:ruby-align" Yes, that right. Thus, correction ok for me. - ed. note in "19.340 style:ruby-position" Hm, this ed. note seems at the wrong place ;-) - ed. note in "19.341 style:run-through" My answer is "Yes" to the first question. My answer to the second questions is, that it depends on the transparent value. If the object 100% transparent, style:run-through values have no different effect. If the object is 1%..99%, the display will differ depending on the fact that the object is displayed in the background or the the foreground. I do not understand the 3rd question. - ed. note in "19.343 style:scale-to-pages" I am fine with the correction - ed. note in "19.346 style:script-type" no input from my side, because I do not know the answer. - ed. note in "19.347 style:shadow" Collapsing is ok for me. Due to the value question, I have no answer. Somebody else? - ed. note in "19.349 style:snap-to-layout-grid" Hm, I do not understand this ed. note. I see no difference between the current text and the text from ODF 1.1 - ed. note in "19.353 style:text-autospace" I do not know this attribute very well. My opinion is that this is space that is add between Asian, Western and complex text *portions*. Thus, it would means that the space is added between characters. Am I right? Please correct me somebody, when I am wrong. - ed. note in "19.355 style:text-combine" No input from my side - I do not know this attribute. - ed. note in "19.358 style:text-emphasize" I agree, but I do not know these definition. Probably, it is very well known for people in this area, what kind of emphasis are possible for Asian text. Then, I would not be needed to define the values. - ed. note in "19.360 style:text-line-through-mode" Ok for me. - ed. notes in "19.361 style:text-line-through-style", "19.364 style:text-line-through-type" and "19.365 style:text-line-through-width" I think it is needed to contact some of my colleagues, which are experts in this area. Currently, the relationship between ...-style and ...-type is not clear to me. I do not know, which attribute specifies that text is lined through. Michael, do you already know the solution? - ed notes in "19.369 style:text-overline-style", "19.370 style:text-overline-type" and "19.371 style:text-overline-width" [same as for ...-line-through-... - see above] - ed note in "19.373 style:text-rotation-angle" I do not why the value range is restricted. Text change is Ok for me. - ed notes in "19.379 style:text-underline-style", "19.380 style:text-underline-type" and "19.381 style:text-underline-width" [same as for ...-line-through-... - see above] - ed note in "19.383 style:use-window-font-color" No input from my side. Somebody else? - ed. note in "19.384.2 <style:table-cell-properties>" Spreadsheet experts should step in here ;-) - ed. note in "19.385 style:vertical-pos" I am fine with the deleted of this text. - ed. note in "19.386 style:vertical-rel Everything is fine from my side. My proposal regarding style:vertical-rel for text:anchor-type="paragraph" and text:anchor-type="char" has been considered correctly, as I see. - ed. note in "19.388 style:wrap" My Ok for the text correction. The "sufficient space left" can be specified by attribute style:wrap-dynamic-threshold. I think we should include a corresponding wording and a reference here. - ed. note in "19.389 style:wrap-contour" I agree. As far as I remember OpenOffice.org Writer support contour wrapping for all frame types. Am I right? What about the other applications? - ed. note in "19.393 style:writing-mode-automatic" I agree. I will consult some of my expert colleagues. Best regards, Oliver -- ======================================================================= Sun Microsystems GmbH Oliver-Rainer Wittmann Nagelsweg 55 Software Engineer - OpenOffice.org/StarOffice 20097 Hamburg Germany Fax: (+49 40) 23 646 955 http://www.sun.de mailto:oliver-rainer.wittmann@sun.com ----------------------------------------------------------------------- Sitz der Gesellschaft: Sun Microsystems GmbH, Sonnenallee 1, D-85551 Kirchheim-Heimstetten Amtsgericht Muenchen: HRB 161028 Geschaeftsfuehrer: Thomas Schroeder, Wolfgang Engels, Dr. Roland Boemer Vorsitzender des Aufsichtsrates: Martin Haering ======================================================================= Oliver-Rainer Wittmann (od) - OpenOffice.org Writer OpenOffice.org Engineering at Sun: http://blogs.sun.com/GullFOSS
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]