Re: [pkcs11] Groups - [X]Salsa20 and [X]Chacha20 (including AEAD) to the Chacha20/Poly1305 proposal uploaded

[Stefan Marsiske <oasis@ctrlc.hu>]

hey,

daniels comments i got today.

On Wed, Feb 07, 2018 at 05:07:49PM +0000, Daniel Minder wrote:
> Hi Stefan,
> 
> Sorry for not replying sooner.
> 
> In general, looks good to me. Some typos should be corrected.
> For MessageEncrypt/MessageDecrypt I proposed some changes to the last Working Draft for GCM/CCM, which I would apply here as well. For example, I would write: "Set  pTag to hold the tag data  returned from C_EncryptMessage() or the final C_EncryptMessageNext()." The current text is IMO not fully correct.
> Also, there seems to be an error in "Call C_EncryptMessage(), or C_EncryptMessageBegin followed by C_EncryptMessageNext()*  mechanism parameter is passed to C_EncryptMessage and C_EncryptMessageBegin()all three of these functions." Is it only passed to C_EncryptMessage and C_EncryptMessageBegin or to all three functions? For GCM/CCM, it's all three. Also, a "The" is missing before "mechanism parameter".
> 
> Best,
> Daniel
> 
> From: pkcs11@lists.oasis-open.org [mailto:pkcs11@lists.oasis-open.org] On Behalf Of Stefan Marsiske
> Sent: Freitag, 26. Januar 2018 16:58
> To: pkcs11@lists.oasis-open.org
> Subject: [pkcs11] Groups - [X]Salsa20 and [X]Chacha20 (including AEAD) to the Chacha20/Poly1305 proposal uploaded
> 
> Submitter's message
> I added the explanation regarding the block counter and also added missing #defines for the AEAD constructions.
> -- Stefan Marsiske
> Document Name: [X]Salsa20 and [X]Chacha20 (including AEAD) to the Chacha20/Poly1305 proposal<https://www.oasis-open.org/apps/org/workgroup/pkcs11/document.php?document_id=62400>
> ________________________________
> No description provided.
> Download Latest Revision<https://www.oasis-open.org/apps/org/workgroup/pkcs11/download.php/62400/latest/CC20_P1305_extended_Proposal.doc>
> Public Download Link<https://www.oasis-open.org/committees/document.php?document_id=62400&wg_abbrev=pkcs11>
> ________________________________
> Submitter: Stefan Marsiske
> Group: OASIS PKCS 11 TC
> Folder: Working Drafts
> Date submitted: 2018-01-26 07:57:22
> 
> 
> 
> ________________________________
> 
> Utimaco IS GmbH
> Germanusstr. 4, D.52080 Aachen, Germany, Tel: +49-241-1696-0, www.utimaco.com
> Seat: Aachen - Registergericht Aachen HRB 18922
> VAT ID No.: DE 815 496 496
> Managementboard: Malte Pollmann (Chairman) CEO, Dr. Frank J. Nellissen CFO
> 
> This communication is confidential. We only send and receive email on the basis of the terms set out at https://www.utimaco.com/en/e-mail-disclaimer/
---end quoted text---