[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [sarif] When columnKind is required
1. The zip file containing the document and JSON schema.2. An editor's report detailing any last-minute changes that needed to be made in order for the changes we agreed on to make sense.
David On 06/06/2018 04:03 PM, Larry Golding (Comcast) wrote:
Option 2 has the advantage that a schema validator can catch the mistake if you omit it.*From:* firstname.lastname@example.org <email@example.com> *On Behalf Of *Larry Golding (Comcast)*Sent:* Wednesday, June 6, 2018 3:52 PM *To:* firstname.lastname@example.org *Subject:* [sarif] When columnKind is required *Importance:* HighWe agreed this morning that there was no default for columnKind. But it doesn’t make sense to require it for tools that don’t analyze text files.I see two options: 1. Say that “If the analysis tool analyzes text files, the run object *SHALL* contain … columnKind … If the analysis tool does not analyze text files, columnKind *SHALL* be absent. 2. Defined another enumerated value "none" for columnKind, and tell analysis tools that don’t analyze text files to use it. Thoughts?I’m going to merge the change as we approved it, but I think we have to fix this.Larry