[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: ISSUE 173: Errors in Test Artifacts for ASM_6022, ASM_5032, ASM_5016
Mike already logged as: http://www.osoa.org/jira/browse/ASSEMBLY-173 On Aug 21, 2009, at 9:15 AM, Mike Edwards wrote: > > Raiser: Mike Edwards > > Target: sca-assembly-1.1-testsuite-cd01.zip > > Description: > > 1) ASM_6022_TestCase > > TestComposite32.composite contains a component reference with a name > "reference1" when the underlying implementation > has the reference name "Reference1": > > <reference name="reference1" multiplicity="1..n"> > > 2) ASM_5032_TestCase > > This testcase uses artifacts with multiple <binding/> subelements > attached to <service/> and <reference/> elements. > However, the Assembly spec requires that where there are multiple > <binding/> subelements present, that each must > have a unique @name value (see ASM90002) - but the artifacts in this > testcase does not give @name values to any of the <binding/> > elements, so violating the Assembly spec unintentionally: > > a) Test_ASM_5032.composite: > > ... > <reference name="Reference1"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1) > "/> > <binding.sca uri="TEST_ASM_5032Component2/Service1"/> > <binding.ws uri="http://localhost:8080/TEST_ASM_5032Component2 > "/> > </reference> > ... > > b) TestComposite15.composite > ... > <service name="Service1" promote="TestComposite15Component1/ > Service1"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1) > "/> > <binding.sca/> > <binding.ws/> > </service> > ... > > 3) ASM_5016_TestCase > > Test_ASM_5016.composite has a component declared with a <service/> > with the name "Service1" when the service in the > underlying implementation is actually called "Service1Superset" - it > is intended that the names should match: > ... > <component name="TEST_ASM_5016Component2"> > <implementation.composite name="test:TestComposite9"/> > <service name="Service1"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1Superset) > "/> > </service> > <property name="serviceName">service2</property> > </component> > ... > > Proposal: > > 1) Change the reference in TestComposite32.composite to use the name > "Reference1": > > <reference name="Reference1" multiplicity="1..n"> > > 2) Update the artifacts so that each <binding/> subelement after the > first one is given an @name attribute with a unique name: > > - this has a consequential update of the target address of the > binding.ws on the reference... > > a) Test_ASM_5032.composite: > > ... > <reference name="Reference1"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1) > "/> > <binding.sca uri="TEST_ASM_5032Component2/Service1"/> > <binding.ws uri="http://localhost:8080/TEST_ASM_5032Component2/Service1/binding2 > " name="binding2"/> > </reference> > ... > > b) TestComposite15.composite > ... > <service name="Service1" promote="TestComposite15Component1/ > Service1"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1) > "/> > <binding.sca/> > <binding.ws name="binding2"/> > </service> > ... > > > 3) Test_ASM_5016.composite > > Update the service name to "Service1Superset" on the component, plus > the reference targets that point to it: > ... > <reference name="Reference1" target="TEST_ASM_5016Component2/ > Service1Superset"> > <!-- Component type has the interface = test.Service1 > - here we use an interface that is a superset --> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1Superset) > "/> > </reference> > </component> > > <component name="TEST_ASM_5016Component2"> > <implementation.composite name="test:TestComposite9"/> > <service name="Service1Superset"> > <interface.wsdl interface="http://test.sca.oasisopen.org/#wsdl.porttype(Service1Superset) > "/> > </service> > <property name="serviceName">service2</property> > </component> > ... > > > Yours, Mike. > > Strategist - Emerging Technologies, SCA & SDO. > Co Chair OASIS SCA Assembly TC. > IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain. > Phone & FAX: +44-1962-818014 Mobile: +44-7802-467431 > Email: mike_edwards@uk.ibm.com > > > > > Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with > number 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire > PO6 3AU > > > > > > >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]