Re: [virtio-comment] [PATCH 15/18] CCW: Separate normative and descriptive sections.

[Cornelia Huck <cornelia.huck@de.ibm.com>]

On Fri, 21 Feb 2014 15:11:44 +1030
Rusty Russell <rusty@au1.ibm.com> wrote:


> I tidied the whole thing up a bit more.    Here's what I've got for now
> in my feedback git tree:
> 
> \devicenormative{Virtio Transport Options / Virtio over channel I/O / Device Operation / Guest->Host Notification}
> The device MUST ignore bits 0-31 (counting from the left) of GPR2.
> This aligns passing the subchannel ID with the way it is passed
> for the existing I/O instructions.
> 
> The driver MAY return a 64-bit host cookie in GPR2 to speed up the

It's the device doing the returning.

> notification execution.
> 
> \drivernormative{Virtio Transport Options / Virtio over channel I/O / Device Operation / Guest->Host Notification}
> 
> For each notification, the driver SHOULD use GPR4 to pass the host cookie received in GPR2 from the previous notication.
> 
> \begin{note}
> For example:
> \begin{lstlisting}
> info->cookie = do_notify(schid,
>                          virtqueue_get_queue_index(vq),
>                          info->cookie);
> \end{lstlisting}
> \end{note}

Otherwise, looks good.