[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH v2] virtio-net: add missing articles for new hdr_len feature
On Wed, Nov 20, 2019 at 02:23:59PM +0100, Cornelia Huck wrote: > And tweak a sentence slightly. > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> > Signed-off-by: Cornelia Huck <cohuck@redhat.com> Thanks! Can you pls add a link to this as a comment to the hdr_len github issue? This way I will remember to pick it up. > --- > > v1->v2: > - add one more tweak [Stefan] > > Note: I have not added definite articles to the feature description; _all_ > features for virtio-net are described in that way, and we should add them > in one go should we decide to change that. > > --- > content.tex | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/content.tex b/content.tex > index 5d3f865956aa..fc59eea95716 100644 > --- a/content.tex > +++ b/content.tex > @@ -3100,8 +3100,8 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De > \begin{itemize} > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has been negotiated, > \field{hdr_len} indicates the header length that needs to be replicated > - for each packet. It's a number of bytes from beginning of the packet > - to beginning of the transport payload. > + for each packet. It's the number of bytes from the beginning of the packet > + to the beginning of the transport payload. > Otherwise, if the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated, > \field{hdr_len} is a hint to the device as to how much of the header > needs to be kept to copy into each packet, usually set to the > @@ -3217,7 +3217,7 @@ \subsubsection{Packet Transmission}\label{sec:Device Types / Network Device / De > > \begin{note} > Caution should be taken by the implementation so as to prevent > - malicious driver from attacking the device by setting incorrect hdr_len. > + a malicious driver from attacking the device by setting an incorrect hdr_len. > \end{note} > > \item If the VIRTIO_NET_F_GUEST_HDRLEN feature has not been negotiated, > -- > 2.21.0
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]