Re: [PATCH 2/2] virtio-gpu: add support for mapping/unmapping blob resources

[Gerd Hoffmann <kraxel@redhat.com>]

  Hi,

> +struct virtio_gpu_resource_map_blob {
> +        struct virtio_gpu_ctrl_hdr hdr;
> +        le32 resource_id;
> +        le32 padding;
> +        le64 offset;
> +};

> +struct virtio_gpu_resource_unmap_blob {
> +        struct virtio_gpu_ctrl_hdr hdr;
> +        le32 resource_id;
> +        le32 padding;
> +};

map has an offset but unmap has not.  So in case a resource has multiple
mappings it is not clear which one is going to be unmapped.  So we
should:

  (a) add offset field to unmap, or
  (b) explicitly specify that unmap will unmap all existing mappings, or
  (c) explicitly specify that multiple mappings are not allowed.

My guess is we want (c) ...

take care,
  Gerd