Re: [virtio-comment] vsock: define a maximum size for the packet data

[Stefano Garzarella <sgarzare@redhat.com>]

On Mon, Apr 4, 2022 at 3:55 PM Laura Loghin <lauralg@amazon.com> wrote:
>
> On 3/28/22 14:14, Stefano Garzarella wrote:
>
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
>
>
>
> On Tue, Mar 22, 2022 at 10:58 AM Loghin, Laura <lauralg@amazon.com> wrote:
>
> Hi,
>
> Sorry for the super late reply! I just sent the patch for the `len` description [1].
>
> Regarding the max size for the packet data, the proposal for adding a field in the config space sounds good to me. What would be some next steps here? Should I send a patch for this one as well?
>
> Yes, please.
>
> From what I understand, we would define a new feature for the max size, and
> add a new field in the config space. Did I misunderstand it?
>
> That's what I would do :-)
> When the feature is negotiated, then the driver should not send
> packets and allocate RX buffers larger than that size.
>
> Thanks,
> Stefano
>
> Hi,
>
> I just sent a patch for the max size config field: https://lists.oasis-open.org/archives/virtio-comment/202204/msg00010.html.

Great! I'll review in the next few days.

> It mostly follows the spec format for MTU. For the max value I used for now the one defined in linux, but should we actually go with a higher one?

Maybe yes, but having the same default value as the current one maybe
simplifies the driver/device for backward compatibility?
Let's discuss it on the patch.

Thanks,
Stefano