Re: [virtio-dev] [PATCH v2] virtio_net: support low and high rate of notification coalescing

[Alvaro Karsz <alvaro.karsz@solid-run.com>]

Hi,

> > This patch adds a new feature, VIRTIO_NET_F_NOTF_COAL_LOW_HIGH, while
> > clarifying/fixing existing coalescing concepts.
> >
> While its visible in the patch itself, what is being done,
> its important to mention the problem statement/motivation for the feature at start of the commit log as first step.
>
> So, can you please describe the motivation, what problem does the new command solve?
> It is likely that control entity which want to set different coalescing parameters likely wants to more than just two values.
> This is something already supported today.

I'll add a better commit log in the next version.

> > On top of the new feature, this patch:
> >       - Unifies the virtio_net_ctrl_coal structs, since the one for tx
> >         and the one for rx are identical.
> >       - Clarifies that the coalescing commands are best-effort.
> >       - Specifies coalescing in respect to delivering interrupts when config
> >           changes.
> >
> They are best to be handled a pre-patch to this one.
> Please split them so that spec improvement work can progress while new features are under review.

ok