Re: [virtio-dev] [PATCH v2] virtio_net: support low and high rate of notification coalescing

[Alvaro Karsz <alvaro.karsz@solid-run.com>]

> By comparison this patch is an attempt to offload ethtool's
> --coalesce parameters to the card. IMO what it misses is
> completeness, e.g. sample-interval is not specified.

AFAIK sample-interval refers to the adaptive coalescing
(adaptive-rx/adaptive-tx) and not to high/low.

include/uapi/linux/ethtool.h:
 * @rate_sample_interval: How often to do adaptive coalescing packet rate
 * sampling, measured in seconds.  Must not be zero.

> Also, introspection is missing and it's useful to avoid
> keeping all state in the driver.

I don't get it, can you please elaborate?