Re: [virtio-dev] [PATCH v5 1/2] content: add virtio file system device

["Michael S. Tsirkin" <mst@redhat.com>]

On Fri, Jul 26, 2019 at 10:53:37AM +0100, Stefan Hajnoczi wrote:
> +\subsubsection{Live migration considerations}\label{sec:Device Types / File System Device / Live Migration Considerations}
> +
> +When a guest is migrated to a new host

Please use driver and device here and elsewhere.

> it is necessary to consider the FUSE
> +session and its state.  The continuity of FUSE inode numbers (also known as
> +nodeids) and fh values is necessary so the driver can continue operation
> +without disruption.
> +
> +It is possible to maintain the FUSE session across live migration either by
> +transferring the state or by redirecting requests from the new host to the old
> +host where the state resides.  The details of how to achieve this are
> +implementation-dependent and are not visible at the device interface level.
> +
> +Maintaining version and feature information negotiated by FUSE\_INIT is
> +necessary so that no FUSE protocol feature changes are visible to the driver
> +across live migration.  The FUSE\_INIT information forms part of the FUSE
> +session state that needs to be transferred during live migration.

It bothers me that it's implicit, and is not exposed easily at the
virtio level, so one has to bind a virtqueue and run buffers over it to
even just check whether a given device supports a specific interface and
can be migrated to.

How about exposing the version of the device in the config space?
Spec can require that it matches the contents of the INIT command.

....

> -- 
> 2.21.0
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
> For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org