[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [PATCH] pci: use msix_config instead of config_msix_vector
On Fri, Oct 11, 2019 at 05:58:59AM -0400, Michael S. Tsirkin wrote: > On Fri, Oct 11, 2019 at 10:42:03AM +0100, Stefan Hajnoczi wrote: > > The struct virtio_pci_common_cfg field is called msix_config but the > > text refers to this field as config_msix_vector. This is confusing. > > > > Rename config_msix_vector to msix_config. Although config_msix_vector > > is arguably a clearer name, existing code using Linux virtio_pci.h uses > > msix_config so let's stick with that. > > > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/41 > > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> > > --- > > Note that Paolo already submitted a patch for the other approach and I > > even reviewed it: > > https://lists.oasis-open.org/archives/virtio/201903/msg00073.html > > > > Either way, let's merge a fix! > > OK I'll start voting on Paolo's patch as it was here earlier. > If that fails we'll vote on yours? Sounds good :). Stefan
Attachment:
signature.asc
Description: PGP signature
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]