Re: [virtio] [PATCH] 4.1.2.5: Legacy: PCI Device Layout: fix PCI header fields order

[Rusty Russell <rusty@au1.ibm.com>]

Pawel Moll <pawel.moll@arm.com> writes:
> The order of the fields in the legacy PCI header seems to get
> messed up in the new spec, with the "Queue Address" moved
> behind "Queue Notify". According to the 0.9.5 version of the spec
> it should be:
>
> * Device Features 32
> * Driver Features 32
> * Queue Address 32
> * Queue Size 16
> * Queue Select 16
> * Queue Notify 16
> * Device Status 8
> * ISR Status 8

Yes, you can see the mistaken transform in 4601066a.

IMHO this qualifies as a minor fix, please apply.

Thanks,
Rusty.

> Reported by a colleague implementing a PCI device - it's got to
> be a copy-and-paste error. The Linux kernel driver definitely
> agrees with the 0.9.5 layout...

Please apologize, and thank them!

Cheers,
Rusty.