Done!
Robert, Phil, all
2 issues WRT the Localization Quality Issue ids.
1) There should be no id on locQualityIssue, singular, the individual entry.. they are NOT referencable individually either in XLIFF 2.1 or in ITS 2.0. Having the individual ids would cause a data model disparity.
2) Great that we now have the id on locQualityIssues, plural, the array wrapper However, this id is not the regular XLIFF id which is an NMToken. This one comes from ITS 2.0 that reuses the xml:id which is stricter, i.e. NCName @Robert van Engelen would you please create the NCName type and use for this id? NCnames will satify NMToken but -- on top of NMToken restrictions -- MUST NOT start with numbers and MUST NOT contain colons.
Although this is the only NCName occurrence to my knowledge s far, I think this should be generalized same as the NMtoken type..
Cheers dF
Dr. David Filip =========== Convenor, JTC 1/SC 42/WG 3 Trustworthiness of AI | National mirror chair, NSAI TC 02/SC 18 AI | Head of the Irish national delegation, ISO/IEC JTC 1/SC 42 AI | Chair & Editor, OASIS XLIFF OMOS TC | Secretary & Lead Editor, OASIS XLIFF TC | NSAI expert to ISO/IEC JTC 1/SC 38 Cloud Computing, ISO TC 37/SC 3 Terminology management, SC 4 Language resources, SC 5 Language technology Moravia Research Fellow
ADAPT Centre KDEG, Trinity College Dublin Mobile: +420-777-218-122
Hi Phil,
The BLUE part is what I changed in the schema to add the id property:
"locQualityIssues": { "description": "A standoff wrapper element to group any number of single issue elements related to the same span of source or target content", "type": "object", "properties": { "id": { "$ref": "#/definitions/NMTOKEN" }, "items": { "type": "array", "items": { "$ref": "#/definitions/locQualityIssue" }, "minItems": 1 } }, "additionalProperties": false, "required": [ "items" ] },
The locQualityIssue type had its id property added some time ago, so I left it untouched.
Thanks.
- Robert
Dr. Robert van Engelen, CEO/CTO Genivia Inc.
Robert
Thanks for the commit but despite your explanation below it looks like you have added the id property to the contained locQualityIssueâs instead of the wrapper. <image001.png> Phil | Phil Ritchieâ | | Chief Technology Officer | | | Vistatec |
|
| Vistatec House, 700 South Circular Road,
Kilmainham, Dublin 8, Ireland. | | | |
| ![Vistatec]( "Vistatec") | | Think Global | |
| Vistatec Ltd. Registered in Ireland 268483. Registered Office, Vistatec House, 700, South Circular Road, Kilmainham. Dublin 8. Ireland.
The information contained in this message, including any accompanying documents, is confidential and is intended only for the addressee(s).
âThe unauthorized use, disclosure, copying, or alteration of this message is strictly forbidden.
If you have received this message in error please notify the sender immediately. |
Phil et al. The JLIFF 2.1 schema in the GitHub repo is updated to include the id property on locQualityIssue. JLIFF the id should be on the wrapper array
This means we need an object that wraps the array. The object will contain the id property and an array property: "its_locQualityIssues": { "description": "A standoff wrapper element to group any number of single issue elements related to the same span of source or target content", "id": { "$ref": "#/definitions/NMTOKEN" }, "items": { "$ref": "#/definitions/its_locQualityIssue" }, "additionalProperties": false, The property name for the the array âitemsâ is somewhat arbitrary. Any ideas for a better name? Dr. Robert van Engelen, CEO/CTO Genivia Inc.
voice: (850) 270 6179 ext 104
fax: (850) 270 6179
mobile: (850) 264 2676
I think we need locQualityIssue to have an id property. Otherwise I see no way to reference an individual issue within an array of locQualityIssues when using standoff.
Phil Ritchieâ | Chief Technology Officer | | | Vistatec |
|
| Vistatec House, 700 South Circular Road,
Kilmainham, Dublin 8, Ireland. | | | | | | ISO 9001 | | | ISO 13485 | | | ISO 17100 | | | ISO 27001 |
|
| | Think Global | |
| Vistatec Ltd. Registered in Ireland 268483. Registered Office, Vistatec House, 700, South Circular Road, Kilmainham. Dublin 8. Ireland.
The information contained in this message, including any accompanying documents, is confidential and is intended only for the addressee(s).
âThe unauthorized use, disclosure, copying, or alteration of this message is strictly forbidden.
If you have received this message in error please notify the sender immediately. |
|