We are also missing the case of the comment annotation using a @ref instead of a @value.
Something like:
<its:locNoteRule selector="//xlf:mrk[@type='comment' and @ref]" locNoteRefPointer="@ref" locNoteType="alert"/>
But this needs to be tweaked for the locNoteType: ‘alert’ if the note has a priority of 1 or none, ‘description’ otherwise.
I’m not sure how you would express this though as the priority value is in the referenced <note>.
Maybe Felix or Soroush have ideas?
-yve
There is at least one other error in a rule:
<its:locNoteRule selector="//xlf:*[@annotation='comment' and @value]" locNotePointer="@value" locNoteType="description"/>
Should be:
<its:locNoteRule selector="//xlf:*[@type='comment' and @value]" locNotePointer="@value" locNoteType="description"/>
Or probably even:
<its:locNoteRule selector="//xlf:mrk[@type='comment' and @value]" locNotePointer="@value" locNoteType="description"/>
Yves Savourel
Localization Solutions Architect | t: 303.951.4523 | f: 303.516.1701 | ENLASO®
I’ve started to look at why our okapi ITS processor was getting a null pointer.
It looks like it’s because the rules are have an attribute localizationNotePointer instead of locNotePointer.
So one more typo to correct.
I’m not sure the expressions work though: I get no error, but no notes associated with nodes either (so far).
Yves Savourel
Localization Solutions Architect | t: 303.951.4523 | f: 303.516.1701 | ENLASO®
From: David Filip [mailto:david.filip@adaptcentre.ie]
Sent: Wednesday, June 21, 2017 6:43 PM
To: Yves Savourel <ysavourel@enlaso.com>
Cc: XLIFF Main List <xliff@lists.oasis-open.org>
Subject: Re: [xliff] ITS rules syntax
Yves, Soroush, Felix, all
Are the rules working now? Was it an easy syntax fix attributable to a typo or export error, but no actual ambiguity as to where on the XLIFF tree the rules apply?
Please let us know, it seems to me that the cs01 fate hinges on the answers to the above questions..
Dr. David Filip
OASIS XLIFF OMOS TC Chair
OASIS XLIFF TC Secretary, Editor, Liaison Officer
KDEG, Trinity College Dublin
On Mon, Jun 19, 2017 at 12:07 AM, Yves Savourel <ysavourel@enlaso.com> wrote:
Thanks Soroush.
I get some null pointer now, but that may be a bug in our ITS engine implementation.
Somehow the selector return null. I’ll have to go debug that…
I believe it was supposed to be
//xlf:file[not(@appliesTo)]//xlf:target...
to select all sources and targets of a file respectively.
Did you really mean “//:” by “/”? (seems to get errors too)
Or “//::” by “/” (seems to be pass, syntactically).
you are right, this is not the correct syntax, probably due to export from Oxygen editor? Anyway replacing //: by / should help.
Are we sure the ITS rules in its.sch (especially the locNoteRule ones) are correct?
I’m getting syntax errors like “A location step was expected following the '/' or '//' token.” When trying to process them.
I’m certainly no XPath expert, but the “//::” parts look odd.
//xlf:file//::xlf:source[ancestor::xlf:file[not(@appliesTo)]/xlf:notes/xlf:note[@priority=1]] | //xlf:file[not(@appliesTo)]//::xlf:target[ancestor::xlf:file[not(@appliesTo)]/xlf:notes/xlf:note[@priority=1]]
Does not pass any online XPath evaluators/validators I’ve tried.