Re: [virtio-comment] virtio sound: add missing definitions for 12 and 24kHz sampling rates

[Anton Yakovlev <anton.yakovlev@opensynergy.com>]

Thanks Pape!

I think that a separate ticket should be created on GitHub for non-editorial
improvements to the specification, and the commit should fix this ticket.


On 29.11.2023 20:33, Pape, Andreas (ADITG/ESS3) wrote:
> Hi Manos,
>
> > Andreas, would you mind re-sending the patch inline as a new thread with git-send-email instead of an attachment? And we can then review it formally.
> sorry, have no mbox access on my devel machine, so here at least as 'inline' patch.
>
>
>  From 067de7a6676dad3ecaaf2316661b0f0057a19cd2 Mon Sep 17 00:00:00 2001
> From: Andreas Pape <apape@de.adit-jv.com>
> Date: Thu, 9 Nov 2023 16:14:57 +0100
> Subject: [PATCH] sound: add sampling rates 12000Hz and 24000Hz
>
> 24kHz is used for 'super wideband' voice transmission
> 12kHz is added 'for completeness'
>
> Signed-off-by: Andreas Pape <apape@de.adit-jv.com>

Reviewed-by: Anton Yakovlev <anton.yakovlev@opensynergy.com>


> ---
>   device-types/sound/description.tex | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/device-types/sound/description.tex b/device-types/sound/description.tex
> index 54c9c8e..bad4415 100644
> --- a/device-types/sound/description.tex
> +++ b/device-types/sound/description.tex
> @@ -504,7 +504,9 @@ \subsubsection{PCM Control Messages}\label{sec:Device Types / Sound Device / Dev
>       VIRTIO_SND_PCM_RATE_96000,
>       VIRTIO_SND_PCM_RATE_176400,
>       VIRTIO_SND_PCM_RATE_192000,
> -    VIRTIO_SND_PCM_RATE_384000
> +    VIRTIO_SND_PCM_RATE_384000,
> +    VIRTIO_SND_PCM_RATE_12000,
> +    VIRTIO_SND_PCM_RATE_24000
>   };
>   
>   struct virtio_snd_pcm_info {

--
Anton Yakovlev
Senior Software Engineer

OpenSynergy GmbH
Rotherstr. 20, 10245 Berlin