[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification
On Thu, Dec 21 2023, Haixu Cui <quic_haixcui@quicinc.com> wrote: > Hi Cornelia, > > On 12/21/2023 4:44 PM, Cornelia Huck wrote: >> On Thu, Dec 21 2023, Haixu Cui <quic_haixcui@quicinc.com> wrote: >>>> Please move inclusion of this new file into content.tex here, instead of >>>> including a not-yet-existing file in the previous patch. >>>> >>>> (...) >>> >>> >>> Sorry, I don't quite understand here. Maybe I should not add the >>> following line in content.tex, is that so? >>> >>> \input{device-types/spi/description.tex} >> >> No, please add this line; but do so in this patch instead of the >> previous one that only changes the wording. > > I am not clear where to put this line? In the commit message or in the > main text, e.g. at the start of the description.tex? As follows: > > diff --git a/device-types/spi/description.tex > b/device-types/spi/description.tex > new file mode 100644 > index 0000000..b76258c > --- /dev/null > +++ b/device-types/spi/description.tex > @@ -0,0 +1,281 @@ > +\input{device-types/spi/description.tex} > +\section{SPI Controller Device}\label{sec:Device Types / SPI Controller > Device} > + > ... Ah no, the inclusion is of course in the right place where you put it in context.tex; the *patch hunk* should be moved from patch 1 to patch 2, that's all. Hope that's more clear now :)
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]