Re: [virtio-comment] Re: [virtio-dev][PATCH V9 2/2] virtio-spi: add the device specification

[Haixu Cui <quic_haixcui@quicinc.com>]

On 12/21/2023 5:54 PM, Cornelia Huck wrote:
> On Thu, Dec 21 2023, Haixu Cui <quic_haixcui@quicinc.com> wrote:
>
> > Hi Cornelia,
> >
> > On 12/21/2023 4:44 PM, Cornelia Huck wrote:
> > > On Thu, Dec 21 2023, Haixu Cui <quic_haixcui@quicinc.com> wrote:
> > > > > Please move inclusion of this new file into content.tex here, instead of
> > > > > including a not-yet-existing file in the previous patch.
> > > > >
> > > > > (...)
> > > >
> > > >
> > > > Sorry, I don't quite understand here. Maybe I should not add the
> > > > following line in content.tex, is that so?
> > > >
> > > > \input{device-types/spi/description.tex}
> > >
> > > No, please add this line; but do so in this patch instead of the
> > > previous one that only changes the wording.
> >
> > I am not clear where to put this line? In the commit message or in the
> > main text, e.g. at the start of the description.tex? As follows:
> >
> > diff --git a/device-types/spi/description.tex
> > b/device-types/spi/description.tex
> > new file mode 100644
> > index 0000000..b76258c
> > --- /dev/null
> > +++ b/device-types/spi/description.tex
> > @@ -0,0 +1,281 @@
> > +\input{device-types/spi/description.tex}
> > +\section{SPI Controller Device}\label{sec:Device Types / SPI Controller
> > Device}
> > +
> > ...
>
> Ah no, the inclusion is of course in the right place where you put it in
> context.tex; the *patch hunk* should be moved from patch 1 to patch 2,
> that's all. Hope that's more clear now :)
Hello Cornelia,

Oh I think I get it. The patch 1 should be split into two. Changing the 
wording is still in patch 1 and the line 
"\input{device-types/spi/description.tex}" should be move to patch 2.

Thank you very much for your detailed explanations, I will do so in next 
patch.

Best Regards
Haixu Cui

> This publicly archived list offers a means to provide input to the
> OASIS Virtual I/O Device (VIRTIO) TC.
>
> In order to verify user consent to the Feedback License terms and
> to minimize spam in the list archive, subscription is required
> before posting.
>
> Subscribe: virtio-comment-subscribe@lists.oasis-open.org
> Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
> List help: virtio-comment-help@lists.oasis-open.org
> List archive: https://lists.oasis-open.org/archives/virtio-comment/
> Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
> List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
> Committee: https://www.oasis-open.org/committees/virtio/
> Join OASIS: https://www.oasis-open.org/join/