Re: [sca-j] JAVA-46: Proposal for ServiceReference equals() method

[Simon Nash <oasis@cjnash.com>]

Mark Combellack wrote:
> Hi,
> 
>  
> 
> Please find the attached proposal for JAVA-46 which adds a description 
> on the equals() and hashCode() method to the ServiceReference. The 
> proposal is based on the original discussions from the November face to 
> face discussions and has been updated to reflect the recent API changes.
> 
>  
> 
> The changes are in section 8.3 and are shown below:
> 
>  
> 
> ·        *equals*(Object anObject) - returns true if and only if 
> anObject is:
> 
I think this is referring to both a) and b), not either a) or b).
This should be stated explicitly.

> ·        a) a ServiceReference object
> 
> ·        b) anObject relates to equivalent reference metadata as the 
> ServiceReference
> 
> Note that “equivalent reference metadata” means that the anObject and 
> the ServiceReference MUST have the same:
> 
> o       Domain URI
> 
> o       Service URI
> 
> o       Binding
> 
> o       Policy
> 
There could be other kinds of metadata not listed here.  For example,
the business interface isn't listed, but (presumably) should be.
Also, the resolution to JAVA-6 might add allowsPassByReference
compatibility as another piece of metadata.  The things you have
listed are fine as examples, but shouldn't appear to be an
exhaustive list.

Also, the MUST above is not a valid RFC2119 MUST.

> In addition, for a callback ServiceReference, as the metadata also 
> includes dynamic information (“EPR”) that cannot be compared, the 
> equals() method MUST only return true if anObject is identically the 
> same as the ServiceReference object.
> 
>  
> 
> ·        *hashCode*() – returns the hash code value for the 
> ServiceReference.
> 
> The exact value returned by the hashCode() method is implementation 
> specific but it MUST obey the general contract defined for the 
> hashCode() method in java.lang.Object.
> 
This does not need to be stated.  It adds nothing to what is already
implied by the Java language spec.

   Simon
>  
> 
> I look forward to your thoughts and comments.
> 
>  
> 
> Thanks,
> 
>  
> 
> Mark
> 
> Mark Combellack| Software Developer| Avaya | Eastern Business Park | St. 
> Mellons | Cardiff | CF3 5EA | Voice: +44 (0) 29 2081 7624 | 
> mcombellack@avaya.com <mailto:|mcombellack@avaya.com>
> 
>  
> 
> 
> ------------------------------------------------------------------------
> 
> ---------------------------------------------------------------------
> To unsubscribe from this mail list, you must leave the OASIS TC that
> generates this mail.  Follow this link to all your TCs in OASIS at:
> https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php