Re: [virtio-comment] Feedback for chapter 5

[Rusty Russell <rusty@au1.ibm.com>]

Thomas Huth <thuth@linux.vnet.ibm.com> writes:
> On Sun, 09 Feb 2014 11:02:24 +1030
> Rusty Russell <rusty@au1.ibm.com> wrote:
>
>> Thomas Huth <thuth@linux.vnet.ibm.com> writes:
>> VIRTIO_CONSOLE_CONSOLE_PORT (4): Sent by the device to nominate
>>   a port as a console port.  There may be more than one console port.
>>   The driver SHOULD treat the port in a manner suitable for text
>>   console access; the driver MUST respond with a VIRTIO_CONSOLE_PORT_OPEN
>>   message.  The driver MUST set value to 1.
>
> I assume the "set value to 1" refers to the VIRTIO_CONSOLE_PORT_OPEN
> event, not the VIRTIO_CONSOLE_CONSOLE_PORT event, right? So I'd maybe
> merge the two sentences to make this more explicit:
>
> "the driver MUST respond with a VIRTIO_CONSOLE_PORT_OPEN message, with
>  value set to 1."

Changed.

Thanks,
Rusty.