RE: [sca-j] Proposal for ISSUE 130: Problems with Example 3 in chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded

[Mike Edwards <mike_edwards@uk.ibm.com>]

Yang Lei, Mark,

Your combined efforts are a big improvement.

One thing I would like to probe is whether
there is a need to use context.createSelfReference() in this example.

I don't see a problem with a Java implementation
class calling one of its methods from within another method,
even where both methods are implementations
of a service interface.  If this is the case, then the use of 
createSelfReference() in this example
seems to make the example more complex than it needs to be,
given that the sample is about annotations
for implementation security policy.  Perhaps I'm missing some subtleties
here and someone can set me straight.


Yours,  Mike.

Strategist - Emerging Technologies, SCA & SDO.
Co Chair OASIS SCA Assembly TC.
IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain.
Phone & FAX: +44-1962-818014    Mobile: +44-7802-467431  
Email:  mike_edwards@uk.ibm.com

From:	"Mark Combellack" <mcombellack@avaya.com>
To:	<yanglei@us.ibm.com>, <sca-j@lists.oasis-open.org>
Date:	13/02/2009 09:57
Subject:	RE: [sca-j] Groups - Proposal for ISSUE 130: Problems with Example 3 in chapter 7   (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded

---

Hi Yang,
 
Thanks for your proposal for Issue 130. 
 
I’ve had a read of the MS Word version of
the proposal and I have updated the MS Word document with the following
changes for your review and comment:

• Missing import of org.oasisopen.sca.ComponentContext as needed by line 842
• Line 854 is wrong as it is attempting to store a ServiceReference returned by createSelfReference() method in a AccountService object.

The line needs
to be:
 
   ServiceReference<AccountService>
accountService = context.createSelfReference(AccountService.class);
 
Also need to add import for ServiceReference.

• Lines 828 & 829 – the import statements for Context and Property have been merged into one line. They should be split
• Lines 854 & 855 – definition of accountService. The line needs to be indented. By 1 space to match the rest of the code in the method. Also, could the line be split so that it does not wrap as this makes it hard to read. i.e. change:

   AccountService accountService
= 
context.createSelfReference(AccountService.class);
 
To:
   AccountService accountService
= 
        context.createSelfReference(AccountService.class);
·
        Line 867 &
868 needs to be split to improve readability and have its indentation corrected.
From
 
checkingAccountSummary.setAccountNumber(checkingAccount.getAccountNumber()
);
 
To:
checkingAccountSummary.setAccountNumber(
     checkingAccount.getAccountNumber());

• Line 871 & 872 need to be split to improve readability. From:

checkingAccountSummary.setBalance(accountService.fromUSDollarToCurrency
       (checkingAccount.getBalance()));
 
To:
checkingAccountSummary.setBalance(
      accountService.fromUSDollarToCurrency
         
       (checkingAccount.getBalance()));

• At various points through the code, MS Word had done the Smart Quote substitution on you and had changed “ “ to sloping quote characters. See lines 839 & 840 for an example. I have changed these back to normal quotes so the code can be copied into Eclipse.
• I’ve put the imports in alphabetical order.

Thanks,
 
Mark
Mark Combellack|
Software Developer|
Avaya |
Eastern Business
Park | St.
Mellons | Cardiff
| CF3
5EA | Voice:
+44 (0) 29 2081 7624 |
mcombellack@avaya.com
> -----Original Message-----
> From: yanglei@us.ibm.com [mailto:yanglei@us.ibm.com]
> Sent: 12 February 2009 22:43
> To: sca-j@lists.oasis-open.org
> Subject: [sca-j] Groups - Proposal
for ISSUE 130: Problems with Example 3
> in chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc)
uploaded
> 
> The document named Proposal for
ISSUE 130: Problems with Example 3 in
> chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc)
has been submitted
> by Ms. Yang Lei to the OASIS Service
Component Architecture / J (SCA-J) TC
> document repository.
> 
> Document Description:
> Thanks Simon for the prior review
and comments
> 
> View Document Details:
> http://www.oasis-open.org/committees/document.php?document_id=31205
> 
> Download Document:
> http://www.oasis-open.org/committees/download.php/31205/sca-javacaa-1.1-
> spec-cd02-rev2%2BIssue130.doc
> 
> 
> PLEASE NOTE:  If the above
links do not work for you, your email
> application
> may be breaking the link into
two pieces.  You may be able to copy and
> paste
> the entire link address into the
address field of your web browser.
> 
> -OASIS Open Administration[attachment
"sca-javacaa-1.1-spec-cd02-rev2 Issue130-rev2a.doc" deleted by
Mike Edwards/UK/IBM] ---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php

---

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU