[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]
Subject: Re: [sca-j] Proposal for ISSUE 130: Problems with Example 3 in chapter7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded
Mark's edits are an improvement, but there is a small problem. The imports for ComponentContext and ServiceReference are using package org.oasisopen.sca.annotation. This should be org.oasisopen.sca, which means some more reordering is needed. Also, the imports for PermitAll, RolesAllowed and RunAs are using the wrong package. It should be javax.annotation. On the other point raised by Mike, I think Dave's option b, as chosen by Yang, is the better solution. It also has the benefit of providing an example of using createSelfReference(), which we don't have anywhere else in the spec. Simon David Booz wrote: > The first question to answer is "What's the scope of the example?" > > If the answer is: to show different policy on different methods then > clearly we need more than one method to illustrate that. Hopefully we > all agree up to this point. > > The existing sample contained a method call to itself, which is > problematic because the policy on the invoked method would have been > ignored since the call was NOT being made through a proxy. What's the > point of an example which shows different policy on different methods > when one of the policies is actually ignored in the sample. > > Therefore, to resolve the problem there are at least two solutions, IMO: > a) remove the internal call from the 1st method to the 2nd - the method > call is not necessary for the example and would shorten it > > b) Change the method call to use a proxy - reinforcing the idea of > "different policy on different methods" idea > > Yang chose (b). I don't have a strong opinion one way or the other. > > Dave Booz > STSM, BPM and SCA Architecture > Co-Chair OASIS SCA-Policy TC and SCA-J TC > "Distributed objects first, then world hunger" > Poughkeepsie, NY (845)-435-6093 or 8-295-6093 > e-mail:booz@us.ibm.com > > Inactive hide details for Mike Edwards ---02/13/2009 06:26:23 AM---Yang > Lei, Mark, Your combined efforts are a big improvement.Mike Edwards > ---02/13/2009 06:26:23 AM---Yang Lei, Mark, Your combined efforts are a > big improvement. > > > From: > Mike Edwards <mike_edwards@uk.ibm.com> > > To: > "OASIS Java" <sca-j@lists.oasis-open.org> > > Date: > 02/13/2009 06:26 AM > > Subject: > RE: [sca-j] Proposal for ISSUE 130: Problems with Example 3 in chapter 7 > (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded > > ------------------------------------------------------------------------ > > > > > Yang Lei, Mark, > > Your combined efforts are a big improvement. > > One thing I would like to probe is whether there is a need to use > context.createSelfReference() in this example. > > I don't see a problem with a Java implementation class calling one of > its methods from within another method, > even where both methods are implementations of a service interface. If > this is the case, then the use of > createSelfReference() in this example seems to make the example more > complex than it needs to be, > given that the sample is about annotations for implementation security > policy. Perhaps I'm missing some subtleties > here and someone can set me straight. > > > Yours, Mike. > > Strategist - Emerging Technologies, SCA & SDO. > Co Chair OASIS SCA Assembly TC. > IBM Hursley Park, Mail Point 146, Winchester, SO21 2JN, Great Britain. > Phone & FAX: +44-1962-818014 Mobile: +44-7802-467431 > Email: mike_edwards@uk.ibm.com > > From: "Mark Combellack" <mcombellack@avaya.com> > To: <yanglei@us.ibm.com>, <sca-j@lists.oasis-open.org> > Date: 13/02/2009 09:57 > Subject: RE: [sca-j] Groups - Proposal for ISSUE 130: Problems with > Example 3 in chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) > uploaded > > > ------------------------------------------------------------------------ > > > > Hi Yang, > > Thanks for your proposal for Issue 130. > > I’ve had a read of the MS Word version of the proposal and I have > updated the MS Word document with the following changes for your review > and comment: > > o Missing import of org.oasisopen.sca.ComponentContext as > needed by line 842 > o Line 854 is wrong as it is attempting to store a > ServiceReference returned by createSelfReference() method in > a AccountService object. > > The line needs to be: > > ServiceReference<AccountService> accountService = > context.createSelfReference(AccountService.class); > > Also need to add import for ServiceReference. > > o Lines 828 & 829 – the import statements for Context and > Property have been merged into one line. They should be split > o Lines 854 & 855 – definition of accountService. The line > needs to be indented. By 1 space to match the rest of the > code in the method. Also, could the line be split so that it > does not wrap as this makes it hard to read. i.e. change: > > > AccountService accountService = > context.createSelfReference(AccountService.class); > > To: > AccountService accountService = > context.createSelfReference(AccountService.class); > · Line 867 & 868 needs to be split to improve readability and have its > indentation corrected. From > > checkingAccountSummary.setAccountNumber(checkingAccount.getAccountNumber() > ); > > To: > checkingAccountSummary.setAccountNumber( > checkingAccount.getAccountNumber()); > > o Line 871 & 872 need to be split to improve readability. From: > > checkingAccountSummary.setBalance(accountService.fromUSDollarToCurrency > (checkingAccount.getBalance())); > > To: > checkingAccountSummary.setBalance( > accountService.fromUSDollarToCurrency > (checkingAccount.getBalance())); > > o At various points through the code, MS Word had done the > Smart Quote substitution on you and had changed “ “ to > sloping quote characters. See lines 839 & 840 for an > example. I have changed these back to normal quotes so the > code can be copied into Eclipse. > o I’ve put the imports in alphabetical order. > > > Thanks, > > Mark > Mark Combellack| Software Developer| Avaya | Eastern Business Park | St. > Mellons | Cardiff | CF3 5EA | Voice: +44 (0) 29 2081 7624 | > _mcombellack@avaya.com_ <mailto:%7Cmcombellack@avaya.com> > > -----Original Message----- > > From: yanglei@us.ibm.com [_mailto:yanglei@us.ibm.com_] > > Sent: 12 February 2009 22:43 > > To: sca-j@lists.oasis-open.org > > Subject: [sca-j] Groups - Proposal for ISSUE 130: Problems with > Example 3 > > in chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) uploaded > > > > The document named Proposal for ISSUE 130: Problems with Example 3 in > > chapter 7 (sca-javacaa-1.1-spec-cd02-rev2+Issue130.doc) has been > submitted > > by Ms. Yang Lei to the OASIS Service Component Architecture / J > (SCA-J) TC > > document repository. > > > > Document Description: > > Thanks Simon for the prior review and comments > > > > View Document Details: > > _http://www.oasis-open.org/committees/document.php?document_id=31205_ > > > > Download Document: > > > _http://www.oasis-open.org/committees/download.php/31205/sca-javacaa-1.1-_ > > spec-cd02-rev2%2BIssue130.doc > > > > > > PLEASE NOTE: If the above links do not work for you, your email > > application > > may be breaking the link into two pieces. You may be able to copy and > > paste > > the entire link address into the address field of your web browser. > > > > -OASIS Open Administration[attachment "sca-javacaa-1.1-spec-cd02-rev2 > Issue130-rev2a.doc" deleted by Mike Edwards/UK/IBM] > --------------------------------------------------------------------- > To unsubscribe from this mail list, you must leave the OASIS TC that > generates this mail. Follow this link to all your TCs in OASIS at:_ > __https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php_ > > > > > ------------------------------------------------------------------------ > / > / > > /Unless stated otherwise above: > IBM United Kingdom Limited - Registered in England and Wales with number > 741598. > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU/ > > > > >
[Date Prev] | [Thread Prev] | [Thread Next] | [Date Next] -- [Date Index] | [Thread Index] | [List Home]